upadhyay-prashant commented on PR #3717:
URL: https://github.com/apache/tinkerpop/pull/3717#issuecomment-6323318889
Thanks @Cole-Greer! I pushed a new revision, rebased on `master`, with the
`is()` chain optimization, the changelog nit, and two off-by-one limit fixes
(`without()` and `not(lte())`). Details are in the review threads.
One thing to flag: with the limit removed from
`match(as("a").out("followedBy").count().is(gt(10)).as("b"), ...)` in
`MatchTest`, `HadoopGraphProcessStandardTest` gets much slower in a full local
build. `GreedyMatchTraversals` now counts every `followedBy` edge on the
Grateful Dead graph, and `hadoop-gremlin` took several hours for me. Removing
the limit is correct there: `b` is joined on the count, and the old cap made
vertices with different counts above 10 match each other. But the test may want
a smaller graph or a different predicate. I'm happy to look at that here or in
a follow-up, whichever you prefer.
Local validation used `mvn clean install -DskipIntegrationTests=false` with
all GLVs enabled. Two things couldn't run locally, and both pass in CI:
`GremlinServerConfigIntegrateTest` (port 8182 is held by another service on my
machine) and the Go integration tests (the test container couldn't reach
`proxy.golang.org`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
