This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git


The following commit(s) were added to refs/heads/master by this push:
     new 873e787514 Send a fixed malformed response from the socket server so 
behavior tests fail the same way each run
873e787514 is described below

commit 873e787514d0edbcb141e2ac9298c382cd9d35a5
Author: Stephen Mallette <[email protected]>
AuthorDate: Wed Oct 21 19:31:40 2026 +0000

    Send a fixed malformed response from the socket server so behavior tests 
fail the same way each run
    
    Assisted-by: Claude Code:claude-opus-5-5
---
 .../tinkerpop/gremlin/socket/server/TestHttpGremlinHandler.java     | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git 
a/gremlin-tools/gremlin-socket-server/src/main/java/org/apache/tinkerpop/gremlin/socket/server/TestHttpGremlinHandler.java
 
b/gremlin-tools/gremlin-socket-server/src/main/java/org/apache/tinkerpop/gremlin/socket/server/TestHttpGremlinHandler.java
index cdc49ff93f..4905280f90 100644
--- 
a/gremlin-tools/gremlin-socket-server/src/main/java/org/apache/tinkerpop/gremlin/socket/server/TestHttpGremlinHandler.java
+++ 
b/gremlin-tools/gremlin-socket-server/src/main/java/org/apache/tinkerpop/gremlin/socket/server/TestHttpGremlinHandler.java
@@ -37,8 +37,8 @@ import org.apache.tinkerpop.gremlin.util.ser.SerTokens;
 import org.apache.tinkerpop.gremlin.util.ser.SerializationException;
 
 import java.nio.charset.StandardCharsets;
+import java.util.Arrays;
 import java.util.Collections;
-import java.util.Random;
 import java.util.concurrent.TimeUnit;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
@@ -162,8 +162,10 @@ public class TestHttpGremlinHandler extends 
SimpleChannelInboundHandler<FullHttp
         response.headers().set(HttpHeaderNames.TRANSFER_ENCODING, 
HttpHeaderValues.CHUNKED);
         ctx.write(response);
 
+        // fixed rather than random bytes, so every run fails the same way: 
0xFF is neither the GraphBinary version
+        // byte nor a type code, which a random first value byte often was, 
letting a reader carry on into the garbage
         final byte[] garbage = new byte[64];
-        new Random().nextBytes(garbage);
+        Arrays.fill(garbage, (byte) 0xFF);
         ctx.write(new 
DefaultHttpContent(ctx.alloc().buffer(64).writeBytes(garbage)));
         ctx.writeAndFlush(new DefaultLastHttpContent());
     }

Reply via email to