svn commit: r1546014 - in /tomee/tomee/trunk/container/openejb-core/src/main: config/pmd/ java/org/apache/openejb/assembler/classic/ java/org/apache/openejb/config/rules/ java/org/apache/openejb/util/proxy/

[tveronezi]

Author: tveronezi
Date: Wed Nov 27 12:30:13 2013
New Revision: 1546014

URL: http://svn.apache.org/r1546014
Log:
https://issues.apache.org/jira/browse/OPENEJB-2050
PMD EmptyStatementNotInLoop

Modified:
    
tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-empty.xml
    
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/LazyEjbReference.java
    
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckClasses.java
    
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/QueryProxy.java

Modified: 
tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-empty.xml
URL: 
http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-empty.xml?rev=1546014&r1=1546013&r2=1546014&view=diff
==============================================================================
--- 
tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-empty.xml 
(original)
+++ 
tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-empty.xml 
Wed Nov 27 12:30:13 2013
@@ -12,7 +12,6 @@
   <rule ref="rulesets/java/empty.xml">
     <exclude name="EmptyCatchBlock"/>
     <exclude name="EmptyIfStmt"/>
-    <exclude name="EmptyStatementNotInLoop"/>
     <exclude name="EmptyWhileStmt"/>
   </rule>
 

Modified: 
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/LazyEjbReference.java
URL: 
http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/LazyEjbReference.java?rev=1546014&r1=1546013&r2=1546014&view=diff
==============================================================================
--- 
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/LazyEjbReference.java
 (original)
+++ 
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/LazyEjbReference.java
 Wed Nov 27 12:30:13 2013
@@ -104,7 +104,7 @@ public class LazyEjbReference extends Re
                 for (Class clazz : 
beanContext.getInterfaces(InterfaceType.BUSINESS_REMOTE)) {
                     if (clazz.getName().equals(info.getInterface())) return 
true;
                 }
-            };
+            }
             default: return false;
         }
     }

Modified: 
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckClasses.java
URL: 
http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckClasses.java?rev=1546014&r1=1546013&r2=1546014&view=diff
==============================================================================
--- 
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckClasses.java
 (original)
+++ 
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckClasses.java
 Wed Nov 27 12:30:13 2013
@@ -157,7 +157,7 @@ public class CheckClasses extends Valida
 
         tag = Strings.lcfirst(Strings.camelCase(tag));
 
-        if (isValidInterface(b, interfce, beanClass, tag));
+        isValidInterface(b, interfce, beanClass, tag);
 
         ClassFinder finder = new ClassFinder(interfce);
 

Modified: 
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/QueryProxy.java
URL: 
http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/QueryProxy.java?rev=1546014&r1=1546013&r2=1546014&view=diff
==============================================================================
--- 
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/QueryProxy.java
 (original)
+++ 
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/QueryProxy.java
 Wed Nov 27 12:30:13 2013
@@ -246,7 +246,6 @@ public class QueryProxy implements Invoc
                 Object idValue;
                 try {
                     idValue = BeanUtils.getProperty(entity, idName);
-                    ;
                 } catch (InvocationTargetException e) {
                     throw new IllegalArgumentException("can't invoke to get 
entity id");
                 } catch (NoSuchMethodException e) {