svn commit: r1546256 - in /tomee/tomee/trunk/container/openejb-core/src/main: config/pmd/openejb-controversial.xml java/org/apache/openejb/ClassLoaderUtil.java

[tveronezi]

Author: tveronezi
Date: Thu Nov 28 02:24:29 2013
New Revision: 1546256

URL: http://svn.apache.org/r1546256
Log:
manually excluding controversial rules.

Modified:
    
tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-controversial.xml
    
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/ClassLoaderUtil.java

Modified: 
tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-controversial.xml
URL: 
http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-controversial.xml?rev=1546256&r1=1546255&r2=1546256&view=diff
==============================================================================
--- 
tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-controversial.xml
 (original)
+++ 
tomee/tomee/trunk/container/openejb-core/src/main/config/pmd/openejb-controversial.xml
 Thu Nov 28 02:24:29 2013
@@ -25,7 +25,22 @@ limitations under the License.
     Custom controversial.xml for openejb-core
   </description>
 
-  <rule ref="rulesets/java/controversial.xml/OneDeclarationPerLine" />
-  <rule ref="rulesets/java/controversial.xml/UnnecessaryConstructor" />
+  <rule ref="rulesets/java/controversial.xml">
+    <exclude name="DataflowAnomalyAnalysis"/>
+    <exclude name="OnlyOneReturn"/>
+    <exclude name="AvoidFinalLocalVariable"/>
+    <exclude name="NullAssignment"/>
+    <exclude name="AvoidLiteralsInIfCondition"/>
+    <exclude name="AtLeastOneConstructor"/>
+    <exclude name="UseConcurrentHashMap"/>
+    <exclude name="AvoidPrefixingMethodParameters"/>
+    <exclude name="CallSuperInConstructor"/>
+    <exclude name="DefaultPackage"/>
+    <exclude name="AvoidUsingShortType"/>
+    <exclude name="UseObjectForClearerAPI"/>
+    <exclude name="AvoidUsingVolatile"/>
+    <exclude name="AssignmentInOperand"/>
+    <exclude name="BooleanInversion"/>
+  </rule>
 
 </ruleset>

Modified: 
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/ClassLoaderUtil.java
URL: 
http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/ClassLoaderUtil.java?rev=1546256&r1=1546255&r2=1546256&view=diff
==============================================================================
--- 
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/ClassLoaderUtil.java
 (original)
+++ 
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/ClassLoaderUtil.java
 Thu Nov 28 02:24:29 2013
@@ -282,7 +282,7 @@ public class ClassLoaderUtil {
                     it.remove();
                     appsByClassLoader.remove(cl);
                     destroyClassLoader(cl);
-                    System.gc();
+                    System.gc(); //NOPMD
                 } else {
                     logger.debug("ClassLoader " + toString(cl) + " held open 
by the applications: " + apps);
                 }