missing test to be useful
Project: http://git-wip-us.apache.org/repos/asf/tomee/repo Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/867cf58a Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/867cf58a Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/867cf58a Branch: refs/heads/develop Commit: 867cf58a8143a2ba1e0c3af2d95d0ba49d5a1b49 Parents: 0370035 Author: Romain Manni-Bucau <[email protected]> Authored: Fri Nov 28 12:31:08 2014 +0100 Committer: Romain Manni-Bucau <[email protected]> Committed: Fri Nov 28 12:31:08 2014 +0100 ---------------------------------------------------------------------- .../main/java/org/apache/openejb/assembler/classic/Assembler.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tomee/blob/867cf58a/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java ---------------------------------------------------------------------- diff --git a/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java b/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java index cd4d0c5..f678345 100644 --- a/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java +++ b/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java @@ -983,7 +983,7 @@ public class Assembler extends AssemblerTool implements org.apache.openejb.spi.A if (si.factoryMethod != null) { query.put("factory-name", si.factoryMethod); } - if (si.constructorArgs != null) { + if (si.constructorArgs != null && !si.constructorArgs.isEmpty()) { query.put("constructor", Join.join(",", si.constructorArgs)); } appInfo.properties.put(si.id, "new://Service?" + URISupport.createQueryString(query));
