Repository: tomee
Updated Branches:
  refs/heads/develop c96e25767 -> 7e20d1628


avoid NPE


Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/7e20d162
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/7e20d162
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/7e20d162

Branch: refs/heads/develop
Commit: 7e20d1628cac43004d2f2d2f55137dfeea2d90a3
Parents: c96e257
Author: Romain Manni-Bucau <[email protected]>
Authored: Tue Dec 2 18:39:34 2014 +0100
Committer: Romain Manni-Bucau <[email protected]>
Committed: Tue Dec 2 18:39:34 2014 +0100

----------------------------------------------------------------------
 .../org/apache/openejb/rest/ThreadLocalSecurityContext.java | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tomee/blob/7e20d162/container/openejb-core/src/main/java/org/apache/openejb/rest/ThreadLocalSecurityContext.java
----------------------------------------------------------------------
diff --git 
a/container/openejb-core/src/main/java/org/apache/openejb/rest/ThreadLocalSecurityContext.java
 
b/container/openejb-core/src/main/java/org/apache/openejb/rest/ThreadLocalSecurityContext.java
index 56e2103..f731bfb 100644
--- 
a/container/openejb-core/src/main/java/org/apache/openejb/rest/ThreadLocalSecurityContext.java
+++ 
b/container/openejb-core/src/main/java/org/apache/openejb/rest/ThreadLocalSecurityContext.java
@@ -54,6 +54,13 @@ public class ThreadLocalSecurityContext extends 
AbstractRestThreadLocalProxy<Sec
     }
 
     public boolean isUserInRole(final String role) {
-        return service().isCallerInRole(role) || get().isUserInRole(role);
+        if (service().isCallerInRole(role)) {
+            return true;
+        }
+        final SecurityContext sc = get();
+        if (sc != null) {
+            return sc.isUserInRole(role);
+        }
+        return false;
     }
 }

Reply via email to