Repository: tomee Updated Branches: refs/heads/master acf9fa5ec -> d9428dd45
static utility classes (including mains) should be final, thanks again checkstyle! Project: http://git-wip-us.apache.org/repos/asf/tomee/repo Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/d9428dd4 Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/d9428dd4 Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/d9428dd4 Branch: refs/heads/master Commit: d9428dd45133929b2f56087c83523133894a51df Parents: acf9fa5 Author: Romain Manni-Bucau <[email protected]> Authored: Wed Mar 18 11:02:46 2015 +0100 Committer: Romain Manni-Bucau <[email protected]> Committed: Wed Mar 18 11:02:46 2015 +0100 ---------------------------------------------------------------------- .../src/main/java/org/apache/openejb/config/EffectiveTomEEXml.java | 2 +- .../src/main/java/org/apache/openejb/util/ListSetters.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tomee/blob/d9428dd4/container/openejb-core/src/main/java/org/apache/openejb/config/EffectiveTomEEXml.java ---------------------------------------------------------------------- diff --git a/container/openejb-core/src/main/java/org/apache/openejb/config/EffectiveTomEEXml.java b/container/openejb-core/src/main/java/org/apache/openejb/config/EffectiveTomEEXml.java index 23c3f7f..499d1f6 100644 --- a/container/openejb-core/src/main/java/org/apache/openejb/config/EffectiveTomEEXml.java +++ b/container/openejb-core/src/main/java/org/apache/openejb/config/EffectiveTomEEXml.java @@ -38,7 +38,7 @@ import static java.util.Arrays.asList; /** * Will dump properties once resolved. */ -public class EffectiveTomEEXml { +public final class EffectiveTomEEXml { public static void main(final String[] args) throws Exception { final CommandLine line = parseCommand(args); if (line == null) { http://git-wip-us.apache.org/repos/asf/tomee/blob/d9428dd4/container/openejb-core/src/main/java/org/apache/openejb/util/ListSetters.java ---------------------------------------------------------------------- diff --git a/container/openejb-core/src/main/java/org/apache/openejb/util/ListSetters.java b/container/openejb-core/src/main/java/org/apache/openejb/util/ListSetters.java index de63f17..794a6d7 100644 --- a/container/openejb-core/src/main/java/org/apache/openejb/util/ListSetters.java +++ b/container/openejb-core/src/main/java/org/apache/openejb/util/ListSetters.java @@ -32,7 +32,7 @@ import java.util.LinkedList; import java.util.List; // this helps to know which setters/properties we can use for nor owned code (OracleXaDataSource is a perfect example) -public class ListSetters { +public final class ListSetters { public static void main(final String[] args) throws Exception { final Options options = new Options(); options.addOption(OptionBuilder
