[
https://issues.apache.org/jira/browse/TOMEE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710201#comment-16710201
]
ASF GitHub Bot commented on TOMEE-2314:
---------------------------------------
Github user rzo1 commented on a diff in the pull request:
https://github.com/apache/tomee/pull/231#discussion_r239105184
--- Diff:
server/openejb-multicast/src/main/java/org/apache/openejb/server/discovery/MulticastDiscoveryAgent.java
---
@@ -46,7 +46,7 @@
*/
public class MulticastDiscoveryAgent implements DiscoveryAgent,
ServerService, SelfManaging {
- private static final Logger log =
Logger.getInstance(LogCategory.OPENEJB_SERVER.createChild("discovery").createChild("multicast"),
MulticastDiscoveryAgent.class);
+ private static final Logger LOG =
Logger.getInstance(LogCategory.OPENEJB_SERVER.createChild("discovery").createChild("multicast"),
MulticastDiscoveryAgent.class);
--- End diff --
Maybe we should change this to `LOGGER` to be consistent throughout the
code-base?
> Code Cleanup: openejb-multicast, openejb-axis, openejb-common-cli,
> openejb-ejbd, openejb-server, openejb-webservices, tomee-common
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TOMEE-2314
> URL: https://issues.apache.org/jira/browse/TOMEE-2314
> Project: TomEE
> Issue Type: Improvement
> Affects Versions: 7.1.0
> Reporter: Hayri Cicek
> Priority: Trivial
> Labels: pull-request-available
>
> This was little to big but next time will make the JIRA issue for each module
> before start coding
> Modules worked in :
> openejb-multicast,
> openejb-axis,
> openejb-common-cli,
> openejb-ejbd,
> openejb-server,
> openejb-webservices,
> tomee-common,
>
> Usage of dimond operator, remove unused import and Java Doc
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
