[
https://issues.apache.org/jira/browse/TOMEE-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710270#comment-16710270
]
ASF GitHub Bot commented on TOMEE-2291:
---------------------------------------
GitHub user josehenriqueventura opened a pull request:
https://github.com/apache/tomee/pull/240
TOMEE-2291 - Fault Tolerance Microprofile example for @Retry
I have finished the implementation of mp-faulttolerance-retry
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/josehenriqueventura/tomee
mp-faulttolerance-retry
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomee/pull/240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #240
----
commit 9bb8a1aef0f81e15502be707aa620addfcad1ab7
Author: josehenriqueventura <j2705hvq*>
Date: 2018-12-03T20:13:20Z
[TOMEE-2291] - Fault Tolerance Microprofile example for @Retry
Created Rest Resource WeatherService which publish /weather
Created WeatherGatewayTimeoutException and
WeatherGatewayBusyServiceException which extends FaultToleranceException to
handle the exceptions thrown by the business logic from WeatherGateway.
Created WeatherGateway which makes the use of @Retry annotation
Created WeatherServiceTest
Created README.md to describe the example (incomplete)
commit bde89d72ea282652034d4b602b6bce6eadd366fb
Author: josehenriqueventura <j2705hvq*>
Date: 2018-12-03T20:17:12Z
[TOMEE-2291] - Fault Tolerance Microprofile example for @Retry
Added missed test for statusOfMonth
Changed the return message of statusOfMonth from weekend to month
commit b45ecda462ea1fbc57c553d4e54ebcb58521cd90
Author: Jose Henrique Ventura <javawebhenrique@...>
Date: 2018-12-03T21:23:36Z
Update README.md
Removed a few things from the README.md to make the text clear.
commit 728c612429ead3711d5a3608e73ba655213cec23
Author: Jose Henrique Ventura <javawebhenrique@...>
Date: 2018-12-03T21:41:26Z
Update README.md
commit 1396ab4409f82f4fdfcf0846bac792434c8f10fb
Author: josehenriqueventura <j2705hvq*>
Date: 2018-12-05T15:33:30Z
[TOMEE-2291] - Fault Tolerance Microprofile example for @Retry
Minimal change for statusOfYear method which had retryOn, maxRetry and
delay parameter removed to retry the same operation for a RuntimeException.
and slight change in README.md file.
commit 20496f9feb10da74c06ef401c2c74404b1a22b5e
Author: Jose Henrique Ventura <javawebhenrique@...>
Date: 2018-12-05T15:44:52Z
Update README.md
Added detail of how to run the test and the path of WeatherServiceTest.java
----
> Fault Tolerance Microprofile example for @Retry
> -----------------------------------------------
>
> Key: TOMEE-2291
> URL: https://issues.apache.org/jira/browse/TOMEE-2291
> Project: TomEE
> Issue Type: Sub-task
> Components: Examples and Documentation
> Affects Versions: 8.0.0-M1
> Reporter: Bruno Baptista
> Assignee: Jonathan Gallimore
> Priority: Major
> Labels: examples, fault-tolerance, microprofile,
> pull-request-available
>
> We would like to have an example for MicroProfile (MP) Fault Tolerance (FT)
> @Retry annotation.
> To get up to speed on the FT MP spec please take a look at these blog posts:
> [https://www.tomitribe.com/blog/microprofile-fault-tolerance-take-2/]
> [https://www.tomitribe.com/blog/microprofile-fault-tolerance-annotations/]
> [https://www.tomitribe.com/blog/tomee-a-tutorial-on-microprofile-fault-tolerance/]
> Example name should be mp-faulttolerance-retry, following the standard
> already in the project.
> All the examples are in:
> [https://github.com/apache/tomee/tree/master/examples]
> See this example of @Counted metrics example for reference:
> [https://github.com/apache/tomee/tree/master/examples/mp-metrics-counted]
> And this example:
> [https://github.com/tomitribe/microprofile-samples/tree/master/fault-tolerance/retry]
> The PR has to contain arquillian tests validating the example.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
