[
https://issues.apache.org/jira/browse/TOMEE-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152883#comment-17152883
]
David Salter commented on TOMEE-1417:
-------------------------------------
Pull request added at: https://github.com/apache/tomee/pull/671
Tests run successfully:
{code}
% mvn -Dtest=SuperPropertiesTest test
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------< org.apache.tomee:openejb-core >--------------------
[INFO] Building TomEE :: Container :: Core 8.0.4-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @
openejb-core ---
[INFO]
[INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles)
@ openejb-core ---
[INFO]
[INFO] --- maven-resources-plugin:3.0.2:resources (default-resources) @
openejb-core ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 44 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-dependency-plugin:3.0.1:copy (copy) @ openejb-core ---
[INFO] Configured Artifact:
org.apache.tomee:openejb-javaagent:8.0.4-SNAPSHOT:jar
[INFO] org.apache.tomee:openejb-javaagent:8.0.4-SNAPSHOT:jar already exists in
/Users/david/Code/tomee/container/openejb-core/target
[INFO]
[INFO] --- maven-compiler-plugin:3.6.2:compile (default-compile) @ openejb-core
---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- dependency-report-plugin:1.0.2:report (default) @ openejb-core ---
[INFO]
[INFO] --- maven-bundle-plugin:3.3.0:manifest (bundle-manifest) @ openejb-core
---
[INFO]
[INFO] --- maven-antrun-plugin:1.8:run (default) @ openejb-core ---
[INFO] Executing tasks
main:
[INFO] Executed tasks
[INFO]
[INFO] --- maven-resources-plugin:3.0.2:testResources (default-testResources) @
openejb-core ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 104 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-dependency-plugin:3.0.1:copy (AlternateDriverJarTest) @
openejb-core ---
[INFO] Configured Artifact: org.apache.derby:derby:10.10.1.1:jar
[INFO] Configured Artifact: org.apache.derby:derby:10.9.1.0:jar
[INFO] org.apache.derby:derby:10.10.1.1:jar already exists in
/Users/david/Code/tomee/container/openejb-core/target/drivers
[INFO] org.apache.derby:derby:10.9.1.0:jar already exists in
/Users/david/Code/tomee/container/openejb-core/target/drivers
[INFO]
[INFO] --- maven-compiler-plugin:3.6.2:testCompile (default-testCompile) @
openejb-core ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:2.21.0:test (default-test) @ openejb-core ---
[INFO]
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.openejb.util.SuperPropertiesTest
[INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.091 s
- in org.apache.openejb.util.SuperPropertiesTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- maven-surefire-plugin:2.21.0:test (test-testng) @ openejb-core ---
[INFO]
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.openejb.util.SuperPropertiesTest
[INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.072 s
- in org.apache.openejb.util.SuperPropertiesTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20.663 s
[INFO] Finished at: 2020-07-07T17:37:35+01:00
[INFO] ------------------------------------------------------------------------
{code}
> [TEST] Incorrect test function PropertiesTest assertTest
> --------------------------------------------------------
>
> Key: TOMEE-1417
> URL: https://issues.apache.org/jira/browse/TOMEE-1417
> Project: TomEE
> Issue Type: Improvement
> Affects Versions: 7.0.0
> Reporter: Daniel Kasmeroglu
> Priority: Trivial
> Fix For: 7.0.9
>
>
> The helper function _PropertiesTest$assertProperties_ contains an invalid
> comparison for a different property:
> {code:java}
> if (expectedValue != expectedValue && (expectedValue == null ||
> !expectedValue.equals(actual))) {
> ...
> }
> {code}
> The comparison *expectedValue != expectedValue* obviously always returns
> false so the contained code will never be executed.
> Furthermore the only use cases of this function returns at it's entry due to
> the fact that the supplied parameters are always equal.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
