[
https://issues.apache.org/jira/browse/TOMEE-2977?focusedWorklogId=567834&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-567834
]
ASF GitHub Bot logged work on TOMEE-2977:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/21 17:13
Start Date: 17/Mar/21 17:13
Worklog Time Spent: 10m
Work Description: rmannibucau commented on a change in pull request #767:
URL: https://github.com/apache/tomee/pull/767#discussion_r596224991
##########
File path: container/openejb-core/pom.xml
##########
@@ -580,6 +580,22 @@
<groupId>org.apache.xbean</groupId>
<artifactId>xbean-bundleutils</artifactId>
</dependency>
+ <dependency>
Review comment:
Hmm, the facts to consider IMHO are:
1. any junit5 dep must not bring back any junit 4 dependency (this creates
weird bugs in test runners for gradle/maven/ide)
2. junit legacy module is completely transversal to app composer so I think
we should keep them orthogonal, can need a better naming but also guarantees a
better design/consumption
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 567834)
Time Spent: 4h 50m (was: 4h 40m)
> Provide a ApplicationComposer JUnit 5 Extension
> -----------------------------------------------
>
> Key: TOMEE-2977
> URL: https://issues.apache.org/jira/browse/TOMEE-2977
> Project: TomEE
> Issue Type: Improvement
> Reporter: Richard Zowalla
> Assignee: Richard Zowalla
> Priority: Major
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> ApplicationComposer relies on JUnit4 code. Might be worth to provide a
> ApplicationComposerExtension to run with JUnit 5 only
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
