[
https://issues.apache.org/jira/browse/TOMEE-4035?focusedWorklogId=808705&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-808705
]
ASF GitHub Bot logged work on TOMEE-4035:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Sep/22 12:44
Start Date: 14/Sep/22 12:44
Worklog Time Spent: 10m
Work Description: jeanouii commented on code in PR #924:
URL: https://github.com/apache/tomee/pull/924#discussion_r970759166
##########
tomee/tomee-microprofile/mp-common/pom.xml:
##########
@@ -138,7 +260,7 @@
<dependency>
<groupId>org.eclipse.microprofile.metrics</groupId>
<artifactId>microprofile-metrics-api</artifactId>
- <version>${microprofile.health.version}</version>
+ <version>${microprofile.metrics.version}</version>
Review Comment:
Good catch but if you have dependency management, shouldn't we take the
version out?
##########
tomee/tomee-microprofile/mp-common/pom.xml:
##########
@@ -84,7 +206,7 @@
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>mp-jwt</artifactId>
- <version>${microprofile.jwt.impl.version}</version>
+ <version>${project.version}</version>
Review Comment:
See previous comment. If you don't change the property, it has
${project.version} already.
##########
tomee/tomee-microprofile/mp-common/pom.xml:
##########
@@ -27,6 +27,128 @@
<artifactId>mp-common</artifactId>
<name>TomEE :: TomEE :: MicroProfile Common</name>
+ <dependencyManagement>
+ <dependencies>
+ <!
Issue Time Tracking
-------------------
Worklog Id: (was: 808705)
Time Spent: 2h 10m (was: 2h)
> Upgrade SmallRye, Jackson and others
> ------------------------------------
>
> Key: TOMEE-4035
> URL: https://issues.apache.org/jira/browse/TOMEE-4035
> Project: TomEE
> Issue Type: Task
> Components: TomEE Build
> Affects Versions: 9.0.0-M8
> Reporter: Gwénaël Ruelland
> Assignee: Gwénaël Ruelland
> Priority: Major
> Fix For: 9.0.0-M9
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> versions of SmallRye that were RC are now stable releases.
> hibernate 6.0 is EOL, use 6.1 instead (compatible jakarta 9.1).
> updated mojarra (faces) to 3.0.2 eclipselink to 3.0.3 krazo (mvc) to 2.0.2
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
