[
https://issues.apache.org/jira/browse/TOMEE-4104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627435#comment-17627435
]
James Parsons commented on TOMEE-4104:
--------------------------------------
Hi [~rzo1]. I submitted a pull request, #956.
I have never contributed to an open source project before, so I hope I did it
right.
> Documentation Website: XA DataSource Configuration: Bug in MySQL Sample Code
> ----------------------------------------------------------------------------
>
> Key: TOMEE-4104
> URL: https://issues.apache.org/jira/browse/TOMEE-4104
> Project: TomEE
> Issue Type: Documentation
> Components: Examples and Documentation, Website
> Affects Versions: 7.0.9, 7.1.5, 9.0.0-M8, 8.0.13
> Reporter: James Parsons
> Priority: Minor
> Labels: documentation
>
> The TomEE documentation website, [XA DataSource Configuration
> page|https://tomee.apache.org/tomee-9.0/docs/configuring-datasources-xa.html],
> MySQL sample code is missing a required {color:#00875a}*</Resource>*{color}
> closing tag.
> The first MySQL resource currently reads:
> {code:xml}
> <Resource id="demo/jdbc/XADataSource" type="DataSource">
> XaDataSource demo/jdbc/XADataSourceXA
> JdbcDriver com.mysql.cj.jdbc.Driver
> JdbcUrl jdbc:mysql://192.168.37.202:3306/movie
> username root
> password my-secret-pw
> JtaManaged true
> InitialSize 10
> MaxActive 128
> MaxIdle 25
> MinIdle 10
> AccessToUnderlyingConnectionAllowed true
> TestOnBorrow false
> TestWhileIdle true
> TimeBetweenEvictionRuns 1 minute
> MaxWaitTime 0 seconds
> ValidationQuery select 1
> {code}
>
> It should be:
> {code:xml}
> <Resource id="demo/jdbc/XADataSource" type="DataSource">
> XaDataSource demo/jdbc/XADataSourceXA
> JdbcDriver com.mysql.cj.jdbc.Driver
> JdbcUrl jdbc:mysql://192.168.37.202:3306/movie
> username root
> password my-secret-pw
> JtaManaged true
> InitialSize 10
> MaxActive 128
> MaxIdle 25
> MinIdle 10
> AccessToUnderlyingConnectionAllowed true
> TestOnBorrow false
> TestWhileIdle true
> TimeBetweenEvictionRuns 1 minute
> MaxWaitTime 0 seconds
> ValidationQuery select 1
> </Resource>
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
