[
https://issues.apache.org/jira/browse/TOMEE-4053?focusedWorklogId=824993&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-824993
]
ASF GitHub Bot logged work on TOMEE-4053:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Nov/22 17:11
Start Date: 10/Nov/22 17:11
Worklog Time Spent: 10m
Work Description: sultan commented on code in PR #963:
URL: https://github.com/apache/tomee/pull/963#discussion_r1019408847
##########
server/openejb-cxf/pom.xml:
##########
@@ -264,7 +264,7 @@
<dependency>
<groupId>com.sun.xml.messaging.saaj</groupId>
<artifactId>saaj-impl</artifactId>
- <version>${saaj-impl.version}</version>
+ <version>${version.impl.saaj}</version>
Review Comment:
The intent was to have all future ambiguous impl in a "version.impl" prefix
like version.impl.activation and version.impl.mail to disambiguate with api
version with prefixes without impl. There should be ambiguity only with those
three. It can be changed to something else entirely if needed.
Issue Time Tracking
-------------------
Worklog Id: (was: 824993)
Time Spent: 8h 20m (was: 8h 10m)
> Dependency properties cleanup
> -----------------------------
>
> Key: TOMEE-4053
> URL: https://issues.apache.org/jira/browse/TOMEE-4053
> Project: TomEE
> Issue Type: Improvement
> Reporter: Gwénaël Ruelland
> Priority: Minor
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> Proposed PR for properties consistency
> * properties are of the form 'version.groupid' or 'groupid.version' :
> changed most to the 'version.groupid' form for coherence.
> * regrouping properties by feature blocks
> * ordering by name were usefull
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
