[ 
https://issues.apache.org/jira/browse/TOMEE-4318?focusedWorklogId=914501&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-914501
 ]

ASF GitHub Bot logged work on TOMEE-4318:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Apr/24 18:37
            Start Date: 13/Apr/24 18:37
    Worklog Time Spent: 10m 
      Work Description: jungm commented on code in PR #1120:
URL: https://github.com/apache/tomee/pull/1120#discussion_r1564185144


##########
tomee/tomee-webaccess/pom.xml:
##########
@@ -42,6 +42,19 @@
         <activeByDefault>true</activeByDefault>
       </activation>
     </profile>
+    <profile>
+      <id>jdk15+</id>
+      <activation>
+        <jdk>[15,)</jdk>

Review Comment:
   imo no reason to hide this dependency inside of a profile if the compile 
level is raised to 17 (also applies to java11plus profile above)



##########
container/openejb-loader/src/main/java/org/apache/openejb/loader/Embedder.java:
##########
@@ -105,6 +105,7 @@ private Class forcefulLoad(final ClassPath classPath, final 
ClassLoader classLoa
             }
             classPath.addJarsToPath(libsDir);
         } catch (final Exception e2) {
+            e2.printStackTrace();

Review Comment:
   Probably unwanted?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 914501)
    Time Spent: 20m  (was: 10m)

> Switch Java Baseline to 17
> --------------------------
>
>                 Key: TOMEE-4318
>                 URL: https://issues.apache.org/jira/browse/TOMEE-4318
>             Project: TomEE
>          Issue Type: Task
>            Reporter: Richard Zowalla
>            Assignee: Richard Zowalla
>            Priority: Major
>             Fix For: 10.0.0-M2
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> CXF 4.1.x will be Java 17, ActiveMQ 6.1.0 (JMS 3) is already Java 17 -> we 
> are forced to make this move as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to