This is an automated email from the ASF dual-hosted git repository.

jlmonteiro pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomee.git


The following commit(s) were added to refs/heads/main by this push:
     new 1e3ec81f6d feat: improve CdiScanner logging and dependencies issues 
only when activated which is now true by default.
1e3ec81f6d is described below

commit 1e3ec81f6d153a7cd036cbb6bbf2fe10be6d8449
Author: Jean-Louis Monteiro <[email protected]>
AuthorDate: Tue May 6 10:50:18 2025 +0200

    feat: improve CdiScanner logging and dependencies issues only when 
activated which is now true by default.
---
 .../src/main/java/org/apache/openejb/cdi/CdiScanner.java         | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git 
a/container/openejb-core/src/main/java/org/apache/openejb/cdi/CdiScanner.java 
b/container/openejb-core/src/main/java/org/apache/openejb/cdi/CdiScanner.java
index 51bd7cd083..f37fb8b264 100644
--- 
a/container/openejb-core/src/main/java/org/apache/openejb/cdi/CdiScanner.java
+++ 
b/container/openejb-core/src/main/java/org/apache/openejb/cdi/CdiScanner.java
@@ -95,7 +95,7 @@ public class CdiScanner implements BdaScannerService {
 
 
     public CdiScanner() {
-        logDebug = 
"true".equals(SystemInstance.get().getProperty("openejb.cdi.noclassdeffound.log",
 "false"));
+        logDebug = 
"true".equals(SystemInstance.get().getProperty("openejb.cdi.noclassdeffound.log",
 "true"));
 
         tomeeBeanArchiveInformation = new 
DefaultBeanArchiveInformation("tomee");
         
tomeeBeanArchiveInformation.setBeanDiscoveryMode(BeanArchiveService.BeanDiscoveryMode.ALL);
@@ -392,16 +392,21 @@ public class CdiScanner implements BdaScannerService {
             tryToMakeItFail(loadClass);
             return loadClass;
         } catch (final ClassNotFoundException e) {
+            Logger.getInstance(LogCategory.OPENEJB_CDI, 
CdiScanner.class).debug("Can not load {0}.", e, className);
             return null;
         } catch (final NoClassDefFoundError e) {
             if (logDebug) {
-                Logger.getInstance(LogCategory.OPENEJB_CDI, 
CdiScanner.class).warning(className + " -> " + e);
+                Logger.getInstance(LogCategory.OPENEJB_CDI, 
CdiScanner.class).warning("Can not load {0} dependencies.", e, className);
             }
+            Logger.getInstance(LogCategory.OPENEJB_CDI, 
CdiScanner.class).debug("Can not load {0} dependencies.", e, className);
             return null;
         }
     }
 
     private void tryToMakeItFail(final Class<?> loadClass) { // we try to 
avoid later NoClassDefFoundError
+        if (!logDebug) {
+            return;
+        }
         loadClass.getDeclaredFields();
         loadClass.getDeclaredMethods();
     }

Reply via email to