rzo1 commented on code in PR #2550:
URL: https://github.com/apache/tomee/pull/2550#discussion_r2937353521


##########
examples/jpa-and-jakarta-data/src/main/resources/META-INF/persistence.xml:
##########


Review Comment:
   The container might supply a default datasource, and in some configurations 
the server might provide a default persistence unit  but in practice you will 
almost always still need a persistence.xml to name the persistence unit and 
wire the data source.
   
   I think that Quarkus can auto-configure the persistence unit (for Hibernate 
for ex) from application.properties, so persistence.xml is optional there.
   
   Bare minimum would be sth like:
   
   ```
   <?xml version="1.0" encoding="UTF-8"?>
   <persistence xmlns="https://jakarta.ee/xml/ns/persistence"; version="3.0">
     <persistence-unit name="myPU" transaction-type="JTA">
       <jta-data-source>jdbc/myDS</jta-data-source>
     </persistence-unit>
   </persistence>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to