jungm commented on PR #2851: URL: https://github.com/apache/tomee/pull/2851#issuecomment-5115023205
Ran a full build with tests locally on JDK 17 (matching the CI workflow's JDK), `clean install -Pstyle,rat -DfailIfNoTests=false` — i.e. the CI command minus the `-DskipTests`. **Result: BUILD SUCCESS, zero test failures across the reactor.** Worth flagging why this needed running by hand: `main-pull-request-build.yml` runs with `-DskipTests`, so the green `build` check on this PR is compile + `style`/`rat` sanity only and never exercised the change. Nothing in PR CI would have caught a regression here. Two caveats, both pre-existing and unrelated to this PR: - `server/openejb-multicast` hangs indefinitely on this machine in `MulticastDiscoveryAgent$Broadcaster.heartbeat` → `DatagramSocket.send` (local network doesn't do multicast). I confirmed the log stopped advancing for ~23 min, killed it, and resumed the reactor from the next module. It fails the same way on an unpatched tree, so it isn't related to this change — but it does mean that one module is unverified locally and I'd rely on CI/another environment for it. - `maven/tomee-maven-plugin` logs `Error occurred during initialization of VM` from a missing third-party artifact (`org.apache.sirona:sirona-javaagent:0.2-incubating:jar:shaded`). The test still passes and the module builds; also pre-existing. `tomee-security` specifically: **108 tests, 0 failures**, with `rat` and `style` clean on the new files. If you'd rather see this on real CI infrastructure than my laptop, I can't trigger an ASF Actions run myself — the workflow is `pull_request`-scoped and already reported. If it's useful I could add a temporary commit enabling tests in the PR workflow so CI runs them, but that's a workflow change I'd rather not sneak into this PR without your say-so. _🤖 Addressed by [Claude Code](https://claude.com/claude-code)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
