jungm commented on PR #2846:
URL: https://github.com/apache/tomee/pull/2846#issuecomment-5122386737

   Good call — done in 3c75c91. `openejb.forceReadOnlyAppNamingContext` is back 
to `false` by default, so nothing changes for existing applications, and the 
TCK turns it on for its runs. I've retitled the PR and rewritten the 
description to match, since it now adds the capability rather than flipping the 
behaviour.
   
   The lifecycle work from the last round stays: when the flag *is* set, the 
contexts are marked at the end of `startEjbs`, so an EAR's late web modules are 
covered and the container's own binds (`app/<module>/<bean>`, 
`comp/EJBContext`, `comp/WebServiceContext`, `comp/TimerService`) all run 
first. Also made the constant `public` so the harness can set it, opted 
`JavaCompReadOnlyTest` into the flag explicitly, and restored 
`EmbeddedTomEEContainerTest.testEjbCanCreateSubContextByDefault` to asserting 
the write succeeds.
   
   Full `openejb-core` suite after the flip: 4096 tests, 6 failures, all the 
pre-existing security ones that reproduce on a clean `main`.
   
   One consequence worth stating plainly: with the default off, TomEE still 
deviates from EE.5.3.4 / Enterprise Beans 10.4.4 out of the box, so the 
behaviour TOMEE-4654 reported is unchanged for anyone who doesn't set the flag. 
Happy to leave it here and revisit the default for a major release, or file a 
follow-up to track it — whichever you prefer.
   
   The matching tomee-tck change (setting the flag in the TomEE config and 
un-excluding the write tests) will be a separate PR there.
   
   _🤖 Addressed by [Claude Code](https://claude.com/claude-code)_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to