This is an automated email from the ASF dual-hosted git repository.
sbp pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-release.git
The following commit(s) were added to refs/heads/main by this push:
new 760e3a8 Improve the message displayed to the user when a vote
announcement email is queued
760e3a8 is described below
commit 760e3a8f5047706fb13bd4a085d483044bdfef0a
Author: Sean B. Palmer <[email protected]>
AuthorDate: Wed Apr 2 14:14:36 2025 +0100
Improve the message displayed to the user when a vote announcement email is
queued
---
atr/routes/candidate.py | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/atr/routes/candidate.py b/atr/routes/candidate.py
index ef452e1..697d204 100644
--- a/atr/routes/candidate.py
+++ b/atr/routes/candidate.py
@@ -208,10 +208,13 @@ async def vote_project(session: routes.CommitterSession,
project_name: str, vers
await data.flush()
await data.commit()
+ # NOTE: During debugging, this email is actually sent elsewhere
+ # TODO: We should perhaps move that logic here, so that we can show
the debugging address
+ # We should also log all outgoing email and the session so that users
can confirm
+ # And can be warned if there was a failure
+ # (The message should be shown on the vote resolution page)
return await session.redirect(
- vote,
- success=f"Vote initiation task queued as task #{task.id}."
- f" You'll receive an email confirmation when complete.",
+ vote, success=f"The vote announcement email will soon be sent to
{email_to} by background task #{task.id}."
)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
