This is an automated email from the ASF dual-hosted git repository.
sbp pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-release.git
The following commit(s) were added to refs/heads/main by this push:
new 20cdf9e Fix a problem with the display of preview files
20cdf9e is described below
commit 20cdf9e2670bd5f8f63f8d627bb8c35ccb827317
Author: Sean B. Palmer <[email protected]>
AuthorDate: Tue Apr 22 14:43:16 2025 +0100
Fix a problem with the display of preview files
---
atr/routes/preview.py | 7 ++++++-
atr/util.py | 5 +++--
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/atr/routes/preview.py b/atr/routes/preview.py
index 22e9fbf..b6761c1 100644
--- a/atr/routes/preview.py
+++ b/atr/routes/preview.py
@@ -233,7 +233,12 @@ async def view(session: routes.CommitterSession,
project_name: str, version_name
)
# Convert async generator to list
- file_stats = [stat async for stat in
util.content_list(util.get_release_preview_dir(), project_name, version_name)]
+ file_stats = [
+ stat
+ async for stat in util.content_list(
+ util.get_release_preview_dir(), project_name, version_name,
release.revision
+ )
+ ]
return await quart.render_template(
"phase-view.html",
diff --git a/atr/util.py b/atr/util.py
index fda0e74..0ee6bb2 100644
--- a/atr/util.py
+++ b/atr/util.py
@@ -191,8 +191,9 @@ async def content_list(
) -> AsyncGenerator[FileStat]:
"""List all the files in the given path."""
base_path = phase_subdir / project_name / version_name
- if (phase_subdir.name == "release-candidate-draft") and (revision_name is
None):
- raise ValueError("A revision name is required for release candidate
draft content listing")
+ if phase_subdir.name in {"release-candidate-draft", "release-preview"}:
+ if revision_name is None:
+ raise ValueError("A revision name is required for release
candidate draft or preview content listing")
if revision_name:
base_path = base_path / revision_name
for path in await paths_recursive(base_path):
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
