This is an automated email from the ASF dual-hosted git repository.
sbp pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-release.git
The following commit(s) were added to refs/heads/main by this push:
new 5261533 Remove unused code that once queried release tasks
5261533 is described below
commit 5261533c54b6822b2fe1bf3edfbb6c7ca5211bfe
Author: Sean B. Palmer <[email protected]>
AuthorDate: Mon Jun 23 15:48:13 2025 +0100
Remove unused code that once queried release tasks
---
atr/db/__init__.py | 1 -
atr/routes/__init__.py | 3 ---
atr/routes/resolve.py | 1 -
atr/routes/vote.py | 6 ++----
4 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/atr/db/__init__.py b/atr/db/__init__.py
index a7bc4b6..e7c1005 100644
--- a/atr/db/__init__.py
+++ b/atr/db/__init__.py
@@ -387,7 +387,6 @@ class Session(sqlalchemy.ext.asyncio.AsyncSession):
_project: bool = True,
_committee: bool = True,
_release_policy: bool = False,
- _tasks: bool = False,
_revisions: bool = False,
) -> Query[models.Release]:
query = sqlmodel.select(models.Release)
diff --git a/atr/routes/__init__.py b/atr/routes/__init__.py
index 3da21ac..7c8ff40 100644
--- a/atr/routes/__init__.py
+++ b/atr/routes/__init__.py
@@ -232,7 +232,6 @@ class CommitterSession:
data: db.Session | None = None,
with_committee: bool = True,
with_project: bool = True,
- with_tasks: bool = False,
with_revisions: bool = False,
) -> models.Release:
# We reuse db.NOT_SET as an entirely different sentinel
@@ -252,7 +251,6 @@ class CommitterSession:
latest_revision_number=latest_revision_number,
_committee=with_committee,
_project=with_project,
- _tasks=with_tasks,
_revisions=with_revisions,
).demand(base.ASFQuartException("Release does not exist",
errorcode=404))
else:
@@ -262,7 +260,6 @@ class CommitterSession:
latest_revision_number=latest_revision_number,
_committee=with_committee,
_project=with_project,
- _tasks=with_tasks,
_revisions=with_revisions,
).demand(base.ASFQuartException("Release does not exist",
errorcode=404))
return release
diff --git a/atr/routes/resolve.py b/atr/routes/resolve.py
index 598a914..ad4adfe 100644
--- a/atr/routes/resolve.py
+++ b/atr/routes/resolve.py
@@ -107,7 +107,6 @@ async def selected_post(
release = await session.release(
project_name,
version_name,
- with_tasks=True,
with_project=True,
phase=models.ReleasePhase.RELEASE_CANDIDATE,
data=data,
diff --git a/atr/routes/vote.py b/atr/routes/vote.py
index 8c2690b..e90ffac 100644
--- a/atr/routes/vote.py
+++ b/atr/routes/vote.py
@@ -51,7 +51,7 @@ async def selected(session: routes.CommitterSession,
project_name: str, version_
await session.check_access(project_name)
release = await session.release(
- project_name, version_name, with_committee=True, with_tasks=True,
phase=models.ReleasePhase.RELEASE_CANDIDATE
+ project_name, version_name, with_committee=True,
phase=models.ReleasePhase.RELEASE_CANDIDATE
)
latest_vote_task = await resolve.release_latest_vote_task(release)
archive_url = None
@@ -81,9 +81,7 @@ async def selected_post(session: routes.CommitterSession,
project_name: str, ver
if await form.validate_on_submit():
# Ensure the release exists and is in the correct phase
- release = await session.release(
- project_name, version_name, with_tasks=True,
phase=models.ReleasePhase.RELEASE_CANDIDATE
- )
+ release = await session.release(project_name, version_name,
phase=models.ReleasePhase.RELEASE_CANDIDATE)
vote = str(form.vote_value.data)
comment = str(form.vote_comment.data)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
