This is an automated email from the ASF dual-hosted git repository.
sbp pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-release.git
The following commit(s) were added to refs/heads/main by this push:
new 414c747 Add notes about release deletion and revisions
414c747 is described below
commit 414c747fe68c9567cf22f6bfb7433c68728401ab
Author: Sean B. Palmer <[email protected]>
AuthorDate: Tue Jul 15 14:11:56 2025 +0100
Add notes about release deletion and revisions
---
atr/db/interaction.py | 6 ++++++
atr/routes/candidate.py | 1 +
2 files changed, 7 insertions(+)
diff --git a/atr/db/interaction.py b/atr/db/interaction.py
index 9797f67..e85a103 100644
--- a/atr/db/interaction.py
+++ b/atr/db/interaction.py
@@ -305,6 +305,12 @@ async def release_delete(
await data.delete(check)
_LOGGER.debug("Deleted %d check results for %s",
len(checks_to_delete), release_name)
+ # TODO: Ensure that revisions are not deleted
+ # But this makes testing difficult
+ # Perhaps delete revisions if associated with test accounts only
+ # But we want to test actual mechanisms, not special case tests
+ # We could create uniquely named releases in tests
+ # Currently part of the discussion in #171, but should be its own issue
await data.delete(release)
_LOGGER.info("Deleted release record: %s", release_name)
await data.commit()
diff --git a/atr/routes/candidate.py b/atr/routes/candidate.py
index 182d347..1d26535 100644
--- a/atr/routes/candidate.py
+++ b/atr/routes/candidate.py
@@ -37,6 +37,7 @@ if asfquart.APP is ...:
@routes.committer("/candidate/delete", methods=["POST"])
async def delete(session: routes.CommitterSession) -> response.Response:
"""Delete a release candidate."""
+ # TODO: We need to never retire revisions, if allowing release deletion
return await session.redirect(root.index, error="Not yet implemented")
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
