This is an automated email from the ASF dual-hosted git repository.
sbp pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-releases.git
The following commit(s) were added to refs/heads/main by this push:
new 5d861df Remove an unused instance of the Jinja2 safe filter
5d861df is described below
commit 5d861df068600b78faee2057246cdeae786e2b25
Author: Sean B. Palmer <[email protected]>
AuthorDate: Mon Oct 27 19:14:48 2025 +0000
Remove an unused instance of the Jinja2 safe filter
---
atr/templates/finish-selected.html | 2 +-
atr/templates/macros/forms.html | 18 +++++++++---------
scripts/markup_strings.py | 1 +
3 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/atr/templates/finish-selected.html
b/atr/templates/finish-selected.html
index 365326a..bea1604 100644
--- a/atr/templates/finish-selected.html
+++ b/atr/templates/finish-selected.html
@@ -197,7 +197,7 @@
<tbody>
{% for original, stripped in rc_affected_paths_preview %}
<tr>
- <td>{{ original | safe }}</td>
+ <td>{{ original }}</td>
<td>{{ stripped }}</td>
</tr>
{% endfor %}
diff --git a/atr/templates/macros/forms.html b/atr/templates/macros/forms.html
index c9551ce..0fdf614 100644
--- a/atr/templates/macros/forms.html
+++ b/atr/templates/macros/forms.html
@@ -60,15 +60,15 @@
{% endif %}
{% endmacro %}
-{% macro errors(field, classes="invalid-feedback", item_separator="<br />") %}
-{% if field.errors %}
- <div class="{{ classes }}">
- {% for error in field.errors %}
- {{ error }}
- {% if not loop.last %}{{ item_separator|safe }}{% endif %}
- {% endfor %}
- </div>
-{% endif %}
+{% macro errors(field, classes="invalid-feedback") %}
+ {% if field.errors %}
+ <div class="{{ classes }}">
+ {% for error in field.errors %}
+ {{ error }}
+ {% if not loop.last %}<br />{% endif %}
+ {% endfor %}
+ </div>
+ {% endif %}
{% endmacro %}
{% macro description(field, classes="form-text text-muted") %}
diff --git a/scripts/markup_strings.py b/scripts/markup_strings.py
index 1b996ef..db23fc7 100755
--- a/scripts/markup_strings.py
+++ b/scripts/markup_strings.py
@@ -18,6 +18,7 @@
# under the License.
# find atr -name '*.py' -exec python3 scripts/markup_strings.py {} \; | grep
-v '^ok '
+# TODO: Detect instances of "| safe" in HTML templates
import ast
import enum
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
