This is an automated email from the ASF dual-hosted git repository.
sbp pushed a commit to branch sbp
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-releases.git
The following commit(s) were added to refs/heads/sbp by this push:
new 121b7184 Make some e2e compose tests more reliable
121b7184 is described below
commit 121b7184985f148bf96b27755bfe0e8a82a96c7e
Author: Sean B. Palmer <[email protected]>
AuthorDate: Thu Mar 12 20:09:18 2026 +0000
Make some e2e compose tests more reliable
---
tests/e2e/compose/conftest.py | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/tests/e2e/compose/conftest.py b/tests/e2e/compose/conftest.py
index a0fb1020..8b722618 100644
--- a/tests/e2e/compose/conftest.py
+++ b/tests/e2e/compose/conftest.py
@@ -61,8 +61,7 @@ def compose_context(browser: Browser) ->
Generator[BrowserContext]:
page.get_by_role("button", name="Add files").click()
page.wait_for_url(f"**/compose/{PROJECT_NAME}/{VERSION_NAME}")
- helpers.visit(page, f"/compose/{PROJECT_NAME}/{VERSION_NAME}")
- _wait_for_tasks_banner_hidden(page, timeout=60000)
+ helpers.wait_for_upload_and_tasks(page, COMPOSE_URL, FILE_NAME)
page.close()
@@ -76,11 +75,6 @@ def page_compose(compose_context: BrowserContext) ->
Generator[Page]:
"""Navigate to the compose page with a fresh page for each test."""
page = compose_context.new_page()
helpers.visit(page, COMPOSE_URL)
- _wait_for_tasks_banner_hidden(page, timeout=60000)
+ page.get_by_role("cell", name=FILE_NAME,
exact=True).wait_for(timeout=60000)
yield page
page.close()
-
-
-def _wait_for_tasks_banner_hidden(page: Page, timeout: int = 30000) -> None:
- """Wait for all background tasks to be completed."""
- page.wait_for_selector("#ongoing-tasks-banner", state="hidden",
timeout=timeout)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
