Repository: incubator-toree Updated Branches: refs/heads/master abcc0c822 -> bb6765bae
TOREE-379: Fix code completion reply. The start and end positions were swapped, causing the front-ends to replace no characters from the partial symbol that is completed. Project: http://git-wip-us.apache.org/repos/asf/incubator-toree/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-toree/commit/a7aa5eb8 Tree: http://git-wip-us.apache.org/repos/asf/incubator-toree/tree/a7aa5eb8 Diff: http://git-wip-us.apache.org/repos/asf/incubator-toree/diff/a7aa5eb8 Branch: refs/heads/master Commit: a7aa5eb8072b7c15edff717c382a155dc52f7a50 Parents: 5887de8 Author: Ryan Blue <b...@apache.org> Authored: Fri Feb 3 14:37:20 2017 -0800 Committer: Ryan Blue <b...@apache.org> Committed: Mon Feb 13 15:04:31 2017 -0800 ---------------------------------------------------------------------- .../toree/kernel/protocol/v5/handler/CodeCompleteHandler.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-toree/blob/a7aa5eb8/kernel/src/main/scala/org/apache/toree/kernel/protocol/v5/handler/CodeCompleteHandler.scala ---------------------------------------------------------------------- diff --git a/kernel/src/main/scala/org/apache/toree/kernel/protocol/v5/handler/CodeCompleteHandler.scala b/kernel/src/main/scala/org/apache/toree/kernel/protocol/v5/handler/CodeCompleteHandler.scala index f03309e..78a7a48 100644 --- a/kernel/src/main/scala/org/apache/toree/kernel/protocol/v5/handler/CodeCompleteHandler.scala +++ b/kernel/src/main/scala/org/apache/toree/kernel/protocol/v5/handler/CodeCompleteHandler.scala @@ -48,8 +48,8 @@ class CodeCompleteHandler(actorLoader: ActorLoader) val codeCompleteFuture = ask(interpreterActor, cr).mapTo[(Int, List[String])] codeCompleteFuture.onComplete { case Success(tuple) => - val reply = CompleteReplyOk(tuple._2, cr.cursor_pos, - tuple._1, Metadata()) + val reply = CompleteReplyOk(tuple._2, tuple._1, + cr.cursor_pos, Metadata()) val completeReplyType = MessageType.Outgoing.CompleteReply.toString logKernelMessageAction("Sending code complete reply for", km) actorLoader.load(SystemActorType.KernelMessageRelay) !
