[trafficcontrol] branch master updated: Traffic Portal tests: Remove interactive browser.debugger() lines (#4854)

[mitchell852]

This is an automated email from the ASF dual-hosted git repository.

mitchell852 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficcontrol.git


The following commit(s) were added to refs/heads/master by this push:
     new ff50ddb  Traffic Portal tests: Remove interactive browser.debugger() 
lines (#4854)
ff50ddb is described below

commit ff50ddbae4011c40cbbaaf82b272faa6807bf009
Author: Zach Hoffman <z...@zrhoffman.net>
AuthorDate: Tue Jul 7 04:01:56 2020 +0000

    Traffic Portal tests: Remove interactive browser.debugger() lines (#4854)
    
    * Remove interactive browser.debugger() lines
    Fixes TypeError: browser.debugger is not a function
    
    * Use protractor major version 7 to run the TP tests
---
 infrastructure/cdn-in-a-box/traffic_portal_integration_test/Dockerfile | 2 +-
 traffic_portal/test/end_to_end/login/login-spec.js                     | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git 
a/infrastructure/cdn-in-a-box/traffic_portal_integration_test/Dockerfile 
b/infrastructure/cdn-in-a-box/traffic_portal_integration_test/Dockerfile
index 00c4dfb..9998f66 100644
--- a/infrastructure/cdn-in-a-box/traffic_portal_integration_test/Dockerfile
+++ b/infrastructure/cdn-in-a-box/traffic_portal_integration_test/Dockerfile
@@ -37,7 +37,7 @@ RUN curl -LO 
https://nodejs.org/dist/v12.16.3/node-v12.16.3-linux-x64.tar.xz
 # Use bsdtar, because regular tar doesn't work with Docker
 RUN yum install -y bsdtar
 RUN bsdtar --strip-components 1 -xzvf node-v* -C /usr/local
-RUN npm install -g protractor
+RUN npm install -g protractor@^7.0.0
 RUN npm install --save-dev jasmine-reporters@^2.0.0
 
 RUN sed -i "s/baseUrl: 'https:\/\/localhost:4443/baseUrl: 
'https:\/\/trafficportal.infra.ciab.test:443/" 
/lang/traffic_portal/test/end_to_end/conf.js
diff --git a/traffic_portal/test/end_to_end/login/login-spec.js 
b/traffic_portal/test/end_to_end/login/login-spec.js
index b83e4ca..501f6db 100644
--- a/traffic_portal/test/end_to_end/login/login-spec.js
+++ b/traffic_portal/test/end_to_end/login/login-spec.js
@@ -36,7 +36,6 @@ describe('Traffic Portal Login Test Suite', function() {
                
browser.driver.findElement(by.name('loginPass')).sendKeys('badPassword');
                browser.driver.findElement(by.name('loginSubmit')).click();
                browser.sleep(250);
-               browser.debugger();
                
expect(browser.driver.findElement(by.css('div.ng-binding')).getText()).toEqual('Invalid
 username or password.');
        });
 
@@ -45,7 +44,6 @@ describe('Traffic Portal Login Test Suite', function() {
                
browser.driver.findElement(by.name('loginUsername')).sendKeys(browser.params.adminUser);
                
browser.driver.findElement(by.name('loginPass')).sendKeys(browser.params.adminPassword);
                browser.driver.findElement(by.name('loginSubmit')).click();
-               browser.debugger();
                
expect(browser.getCurrentUrl().then(commonFunctions.urlPath)).toEqual(commonFunctions.urlPath(browser.baseUrl)+"#!/cdns");
        });
 });