This is an automated email from the ASF dual-hosted git repository.
zrhoffman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficcontrol.git
The following commit(s) were added to refs/heads/master by this push:
new 70f0f76da7 Add a button to toggle the visibility of all sensitive
fields to DS forms (#7184)
70f0f76da7 is described below
commit 70f0f76da7b301a5949233a983885456f8179d78
Author: ocket8888 <[email protected]>
AuthorDate: Mon Nov 21 08:50:53 2022 -0700
Add a button to toggle the visibility of all sensitive fields to DS forms
(#7184)
---
.../form/deliveryService/FormDeliveryServiceController.js | 2 ++
.../form/deliveryService/form.deliveryService.DNS.tpl.html | 13 +++++++------
.../form/deliveryService/form.deliveryService.HTTP.tpl.html | 13 +++++++------
.../deliveryService/form.deliveryService.anyMap.tpl.html | 3 ++-
4 files changed, 18 insertions(+), 13 deletions(-)
diff --git
a/traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js
b/traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js
index bfff737626..87fd80153d 100644
---
a/traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js
+++
b/traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js
@@ -25,6 +25,8 @@ var FormDeliveryServiceController = function(deliveryService,
dsCurrent, origin,
*/
let cachedTLSVersions = null;
+ $scope.showSensitive = false;
+
const knownVersions = new Set(["1.0", "1.1", "1.2", "1.3"]);
$scope.tlsVersionUnknown = v => v && !knownVersions.has(v);
diff --git
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
index 6676ac730e..44c1a98c66 100644
---
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
+++
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
@@ -39,6 +39,7 @@ under the License.
</div>
</div>
<div class="pull-right" role="group">
+ <button type="button" class="btn btn-primary"
ng-click="showSensitive = !showSensitive">Toggle Sensitive Field Blur</button>
<button type="button" class="btn btn-danger"
ng-if="!settings.isNew && !settings.isRequest" ng-disabled="!deletable()"
ng-click="confirmDelete(deliveryService)">{{settings.deleteLabel}}</button>
<button class="btn btn-success" ng-if="!settings.isRequest"
ng-disabled="deliveryServiceForm.$pristine || deliveryServiceForm.$invalid ||
!saveable()" ng-click="save(deliveryService)">{{settings.saveLabel}}</button>
<button type="button" class="btn btn-primary"
ng-if="!settings.isRequest && !settings.isNew" title="Delivery Service Charts"
ng-if="showChartsButton" ng-click="openCharts(deliveryService)"><i class="fa
fa-bar-chart fa-fw"></i></button>
@@ -653,7 +654,7 @@ under the License.
</div>
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <textarea id="edgeHeaderRewrite"
name="edgeHeaderRewrite" class="form-control private-text"
ng-model="deliveryService.edgeHeaderRewrite"
ng-maxlength="(deliveryService.topology) ? 0 : ''" rows="3"></textarea>
+ <textarea id="edgeHeaderRewrite"
name="edgeHeaderRewrite" class="form-control" ng-class="{'private-text':
!showSensitive}" ng-model="deliveryService.edgeHeaderRewrite"
ng-maxlength="(deliveryService.topology) ? 0 : ''" rows="3"></textarea>
<small class="input-error"
ng-show="hasPropertyError(cacheConfig.edgeHeaderRewrite, 'maxlength')">Only
applicable with non topology-based delivery services</small>
<aside class="current-value"
ng-if="settings.isRequest" ng-show="deliveryService.edgeHeaderRewrite !=
dsCurrent.edgeHeaderRewrite">
<h3 ng-if="open()">Current Value</h3>
@@ -678,7 +679,7 @@ under the License.
</div>
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <textarea id="midHeaderRewrite"
name="midHeaderRewrite" class="form-control private-text"
ng-model="deliveryService.midHeaderRewrite"
ng-maxlength="(deliveryService.topology) ? 0 : ''" rows="3"></textarea>
+ <textarea id="midHeaderRewrite"
name="midHeaderRewrite" class="form-control" ng-class="{'private-text':
!showSensitive}" ng-model="deliveryService.midHeaderRewrite"
ng-maxlength="(deliveryService.topology) ? 0 : ''" rows="3"></textarea>
<small class="input-error"
ng-show="hasPropertyError(cacheConfig.midHeaderRewrite, 'maxlength')">Only
applicable with non topology-based delivery services</small>
<aside class="current-value"
ng-if="settings.isRequest" ng-show="deliveryService.midHeaderRewrite !=
dsCurrent.midHeaderRewrite">
<h3 ng-if="open()">Current Value</h3>
@@ -703,7 +704,7 @@ under the License.
</div>
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <textarea id="firstHeaderRewrite"
name="firstHeaderRewrite" class="form-control private-text"
ng-model="deliveryService.firstHeaderRewrite"
ng-maxlength="(!deliveryService.topology) ? 0 : ''" rows="3"></textarea>
+ <textarea id="firstHeaderRewrite"
name="firstHeaderRewrite" class="form-control" ng-class="{'private-text':
!showSensitive}" ng-model="deliveryService.firstHeaderRewrite"
ng-maxlength="(!deliveryService.topology) ? 0 : ''" rows="3"></textarea>
<small class="input-error"
ng-show="hasPropertyError(cacheConfig.firstHeaderRewrite, 'maxlength')">Only
applicable with topology-based delivery services</small>
<aside class="current-value"
ng-if="settings.isRequest" ng-show="deliveryService.firstHeaderRewrite !=
dsCurrent.firstHeaderRewrite">
<h3 ng-if="open()">Current Value</h3>
@@ -728,7 +729,7 @@ under the License.
</div>
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <textarea id="innerHeaderRewrite"
name="innerHeaderRewrite" class="form-control private-text"
ng-model="deliveryService.innerHeaderRewrite"
ng-maxlength="(!deliveryService.topology) ? 0 : ''" rows="3"></textarea>
+ <textarea id="innerHeaderRewrite"
name="innerHeaderRewrite" class="form-control" ng-class="{'private-text':
!showSensitive}" ng-model="deliveryService.innerHeaderRewrite"
ng-maxlength="(!deliveryService.topology) ? 0 : ''" rows="3"></textarea>
<small class="input-error"
ng-show="hasPropertyError(cacheConfig.innerHeaderRewrite, 'maxlength')">Only
applicable with topology-based delivery services</small>
<aside class="current-value"
ng-if="settings.isRequest" ng-show="deliveryService.innerHeaderRewrite !=
dsCurrent.innerHeaderRewrite">
<h3 ng-if="open()">Current Value</h3>
@@ -753,7 +754,7 @@ under the License.
</div>
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <textarea id="lastHeaderRewrite"
name="lastHeaderRewrite" class="form-control private-text"
ng-model="deliveryService.lastHeaderRewrite"
ng-maxlength="(!deliveryService.topology) ? 0 : ''" rows="3"></textarea>
+ <textarea id="lastHeaderRewrite"
name="lastHeaderRewrite" class="form-control" ng-class="{'private-text':
!showSensitive}" ng-model="deliveryService.lastHeaderRewrite"
ng-maxlength="(!deliveryService.topology) ? 0 : ''" rows="3"></textarea>
<small class="input-error"
ng-show="hasPropertyError(cacheConfig.lastHeaderRewrite, 'maxlength')">Only
applicable with topology-based delivery services</small>
<aside class="current-value"
ng-if="settings.isRequest" ng-show="deliveryService.lastHeaderRewrite !=
dsCurrent.lastHeaderRewrite">
<h3 ng-if="open()">Current Value</h3>
@@ -792,7 +793,7 @@ under the License.
</div>
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <textarea id="remapText" name="remapText"
class="form-control private-text" ng-model="deliveryService.remapText"
ng-pattern="/^[^\n\r]*$/" rows="3"></textarea>
+ <textarea id="remapText" name="remapText"
class="form-control" ng-class="{'private-text': !showSensitive}"
ng-model="deliveryService.remapText" ng-pattern="/^[^\n\r]*$/"
rows="3"></textarea>
<small class="input-error"
ng-show="hasPropertyError(cacheConfig.remapText, 'pattern')">No Line
Breaks</small>
<aside class="current-value"
ng-if="settings.isRequest" ng-show="deliveryService.remapText !=
dsCurrent.remapText">
<h3 ng-if="open()">Current Value</h3>
diff --git
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.HTTP.tpl.html
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.HTTP.tpl.html
index 8db16276ea..ddc229de94 100644
---
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.HTTP.tpl.html
+++
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.HTTP.tpl.html
@@ -39,6 +39,7 @@ under the License.
</div>
</div>
<div class="pull-right" role="group">
+ <button type="button" class="btn btn-primary"
ng-click="showSensitive = !showSensitive">Toggle Sensitive Field Blur</button>
<button type="button" class="btn btn-danger"
ng-if="!settings.isNew && !settings.isRequest" ng-disabled="!deletable()"
ng-click="confirmDelete(deliveryService)">{{settings.deleteLabel}}</button>
<button class="btn btn-success" ng-if="!settings.isRequest"
ng-disabled="deliveryServiceForm.$pristine || deliveryServiceForm.$invalid ||
!saveable()" ng-click="save(deliveryService)">{{settings.saveLabel}}</button>
<button type="button" class="btn btn-primary"
ng-if="!settings.isRequest && !settings.isNew" title="Delivery Service Charts"
ng-if="showChartsButton" ng-click="openCharts(deliveryService)"><i class="fa
fa-bar-chart fa-fw"></i></button>
@@ -653,7 +654,7 @@ under the License.
</div>
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <textarea id="edgeHeaderRewrite"
name="edgeHeaderRewrite" class="form-control private-text"
ng-model="deliveryService.edgeHeaderRewrite"
ng-maxlength="(deliveryService.topology) ? 0 : ''" rows="3"></textarea>
+ <textarea id="edgeHeaderRewrite"
name="edgeHeaderRewrite" class="form-control" ng-class="{'private-text':
!showSensitive}" ng-model="deliveryService.edgeHeaderRewrite"
ng-maxlength="(deliveryService.topology) ? 0 : ''" rows="3"></textarea>
<small class="input-error"
ng-show="hasPropertyError(cacheConfig.edgeHeaderRewrite, 'maxlength')">Only
applicable with non topology-based delivery services</small>
<aside class="current-value"
ng-if="settings.isRequest" ng-show="deliveryService.edgeHeaderRewrite !=
dsCurrent.edgeHeaderRewrite">
<h3 ng-if="open()">Current Value</h3>
@@ -678,7 +679,7 @@ under the License.
</div>
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <textarea id="midHeaderRewrite"
name="midHeaderRewrite" class="form-control private-text"
ng-model="deliveryService.midHeaderRewrite"
ng-maxlength="(deliveryService.topology) ? 0 : ''" rows="3"></textarea>
+ <textarea id="midHeaderRewrite"
name="midHeaderRewrite" class="form-control" ng-class="{'private-text':
!showSensitive}" ng-model="deliveryService.midHeaderRewrite"
ng-maxlength="(deliveryService.topology) ? 0 : ''" rows="3"></textarea>
<small class="input-error"
ng-show="hasPropertyError(cacheConfig.midHeaderRewrite, 'maxlength')">Only
applicable with non topology-based delivery services</small>
<aside class="current-value"
ng-if="settings.isRequest" ng-show="deliveryService.midHeaderRewrite !=
dsCurrent.midHeaderRewrite">
<h3 ng-if="open()">Current Value</h3>
@@ -703,7 +704,7 @@ under the License.
</div>
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <textarea id="firstHeaderRewrite"
name="firstHeaderRewrite" class="form-control private-text"
ng-model="deliveryService.firstHeaderRewrite"
ng-maxlength="(!deliveryService.topology) ? 0 : ''" rows="3"></textarea>
+ <textarea id="firstHeaderRewrite"
name="firstHeaderRewrite" class="form-control" ng-class="{'private-text':
!showSensitive}" ng-model="deliveryService.firstHeaderRewrite"
ng-maxlength="(!deliveryService.topology) ? 0 : ''" rows="3"></textarea>
<small class="input-error"
ng-show="hasPropertyError(cacheConfig.firstHeaderRewrite, 'maxlength')">Only
applicable with topology-based delivery services</small>
<aside class="current-value"
ng-if="settings.isRequest" ng-show="deliveryService.firstHeaderRewrite !=
dsCurrent.firstHeaderRewrite">
<h3 ng-if="open()">Current Value</h3>
@@ -728,7 +729,7 @@ under the License.
</div>
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <textarea id="innerHeaderRewrite"
name="innerHeaderRewrite" class="form-control private-text"
ng-model="deliveryService.innerHeaderRewrite"
ng-maxlength="(!deliveryService.topology) ? 0 : ''" rows="3"></textarea>
+ <textarea id="innerHeaderRewrite"
name="innerHeaderRewrite" class="form-control" ng-class="{'private-text':
!showSensitive}" ng-model="deliveryService.innerHeaderRewrite"
ng-maxlength="(!deliveryService.topology) ? 0 : ''" rows="3"></textarea>
<small class="input-error"
ng-show="hasPropertyError(cacheConfig.innerHeaderRewrite, 'maxlength')">Only
applicable with topology-based delivery services</small>
<aside class="current-value"
ng-if="settings.isRequest" ng-show="deliveryService.innerHeaderRewrite !=
dsCurrent.innerHeaderRewrite">
<h3 ng-if="open()">Current Value</h3>
@@ -753,7 +754,7 @@ under the License.
</div>
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <textarea id="lastHeaderRewrite"
name="lastHeaderRewrite" class="form-control private-text"
ng-model="deliveryService.lastHeaderRewrite"
ng-maxlength="(!deliveryService.topology) ? 0 : ''" rows="3"></textarea>
+ <textarea id="lastHeaderRewrite"
name="lastHeaderRewrite" class="form-control" ng-class="{'private-text':
!showSensitive}" ng-model="deliveryService.lastHeaderRewrite"
ng-maxlength="(!deliveryService.topology) ? 0 : ''" rows="3"></textarea>
<small class="input-error"
ng-show="hasPropertyError(cacheConfig.lastHeaderRewrite, 'maxlength')">Only
applicable with topology-based delivery services</small>
<aside class="current-value"
ng-if="settings.isRequest" ng-show="deliveryService.lastHeaderRewrite !=
dsCurrent.lastHeaderRewrite">
<h3 ng-if="open()">Current Value</h3>
@@ -792,7 +793,7 @@ under the License.
</div>
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <textarea id="remapText" name="remapText"
class="form-control private-text" ng-model="deliveryService.remapText"
ng-pattern="/^[^\n\r]*$/" rows="3"></textarea>
+ <textarea id="remapText" name="remapText"
class="form-control" ng-class="{'private-text': !showSensitive}"
ng-model="deliveryService.remapText" ng-pattern="/^[^\n\r]*$/"
rows="3"></textarea>
<small class="input-error"
ng-show="hasPropertyError(cacheConfig.remapText, 'pattern')">No Line
Breaks</small>
<aside class="current-value"
ng-if="settings.isRequest" ng-show="deliveryService.remapText !=
dsCurrent.remapText">
<h3 ng-if="open()">Current Value</h3>
diff --git
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.anyMap.tpl.html
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.anyMap.tpl.html
index 135445af1a..f27f93b522 100644
---
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.anyMap.tpl.html
+++
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.anyMap.tpl.html
@@ -39,6 +39,7 @@ under the License.
</div>
</div>
<div class="pull-right" role="group">
+ <button type="button" class="btn btn-primary"
ng-click="showSensitive = !showSensitive">Toggle Sensitive Field Blur</button>
<button type="button" class="btn btn-danger"
ng-if="!settings.isNew && !settings.isRequest" ng-disabled="!deletable()"
ng-click="confirmDelete(deliveryService)">{{settings.deleteLabel}}</button>
<button class="btn btn-success" ng-if="!settings.isRequest"
ng-disabled="deliveryServiceForm.$pristine || deliveryServiceForm.$invalid ||
!saveable()" ng-click="save(deliveryService)">{{settings.saveLabel}}</button>
<button type="button" class="btn btn-primary"
ng-if="!settings.isRequest && !settings.isNew" title="Delivery Service Charts"
ng-if="showChartsButton" ng-click="openCharts(deliveryService)"><i class="fa
fa-bar-chart fa-fw"></i></button>
@@ -372,7 +373,7 @@ under the License.
</div>
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <textarea id="remapText" name="remapText"
class="form-control private-text" ng-model="deliveryService.remapText"
ng-pattern="/^[^\n\r]*$/" rows="3" required></textarea>
+ <textarea id="remapText" name="remapText"
class="form-control" ng-class="{'private-text': !showSensitive}"
ng-model="deliveryService.remapText" ng-pattern="/^[^\n\r]*$/" rows="3"
required></textarea>
<small class="input-error"
ng-show="hasPropertyError(cacheConfig.remapText, 'pattern')">No Line
Breaks</small>
<aside class="current-value"
ng-if="settings.isRequest" ng-show="deliveryService.remapText !=
dsCurrent.remapText">
<h3 ng-if="open()">Current Value</h3>
