This is an automated email from the ASF dual-hosted git repository. rshah pushed a commit to branch feature/tpv2-role-details in repository https://gitbox.apache.org/repos/asf/trafficcontrol.git
commit 36c3d85e5fb8b4ba6c81929af7031386f3c642d0 Author: Rima Shah <[email protected]> AuthorDate: Wed May 10 23:54:36 2023 -0600 Fixed Lint Issues --- experimental/traffic-portal/nightwatch/globals/globals.ts | 2 +- experimental/traffic-portal/src/app/api/testing/user.service.ts | 2 +- experimental/traffic-portal/src/app/core/core.module.ts | 2 +- .../src/app/core/users/roles/detail/role-detail.component.spec.ts | 6 +++--- .../src/app/core/users/roles/detail/role-detail.component.ts | 4 ++-- .../src/app/core/users/roles/table/roles-table.component.ts | 6 ++++-- 6 files changed, 12 insertions(+), 10 deletions(-) diff --git a/experimental/traffic-portal/nightwatch/globals/globals.ts b/experimental/traffic-portal/nightwatch/globals/globals.ts index 4034d330cb..57dfe76a15 100644 --- a/experimental/traffic-portal/nightwatch/globals/globals.ts +++ b/experimental/traffic-portal/nightwatch/globals/globals.ts @@ -40,8 +40,8 @@ import type { ServersPageObject } from "nightwatch/page_objects/servers/servers" import type { StatusDetailPageObject } from "nightwatch/page_objects/statuses/statusDetail"; import type { StatusesTablePageObject } from "nightwatch/page_objects/statuses/statusesTable"; import type { ChangeLogsPageObject } from "nightwatch/page_objects/users/changeLogs"; -import type { RolesPageObject } from "nightwatch/page_objects/users/rolesTable"; import type { RoleDetailPageObject } from "nightwatch/page_objects/users/roleDetail"; +import type { RolesPageObject } from "nightwatch/page_objects/users/rolesTable"; import type { TenantDetailPageObject } from "nightwatch/page_objects/users/tenantDetail"; import type { TenantsPageObject } from "nightwatch/page_objects/users/tenants"; import type { UsersPageObject } from "nightwatch/page_objects/users/users"; diff --git a/experimental/traffic-portal/src/app/api/testing/user.service.ts b/experimental/traffic-portal/src/app/api/testing/user.service.ts index e176d4ce9f..5afbcd3b8f 100644 --- a/experimental/traffic-portal/src/app/api/testing/user.service.ts +++ b/experimental/traffic-portal/src/app/api/testing/user.service.ts @@ -470,7 +470,7 @@ export class UserService { /** * Deletes an existing role. * - * @param tenant The role to be deleted. + * @param role The role to be deleted. * @returns The deleted role. */ public async deleteRole(role: string | ResponseRole): Promise<ResponseRole> { diff --git a/experimental/traffic-portal/src/app/core/core.module.ts b/experimental/traffic-portal/src/app/core/core.module.ts index e9b68f3cd6..0b2ef0a59b 100644 --- a/experimental/traffic-portal/src/app/core/core.module.ts +++ b/experimental/traffic-portal/src/app/core/core.module.ts @@ -61,8 +61,8 @@ import { StatusDetailsComponent } from "./statuses/status-details/status-details import { StatusesTableComponent } from "./statuses/statuses-table/statuses-table.component"; import { TypeDetailComponent } from "./types/detail/type-detail.component"; import { TypesTableComponent } from "./types/table/types-table.component"; -import { RolesTableComponent } from "./users/roles/table/roles-table.component"; import { RoleDetailComponent } from "./users/roles/detail/role-detail.component"; +import { RolesTableComponent } from "./users/roles/table/roles-table.component"; import { TenantDetailsComponent } from "./users/tenants/tenant-details/tenant-details.component"; import { TenantsComponent } from "./users/tenants/tenants.component"; import { UserDetailsComponent } from "./users/user-details/user-details.component"; diff --git a/experimental/traffic-portal/src/app/core/users/roles/detail/role-detail.component.spec.ts b/experimental/traffic-portal/src/app/core/users/roles/detail/role-detail.component.spec.ts index 6e1d180395..22c647a5f2 100644 --- a/experimental/traffic-portal/src/app/core/users/roles/detail/role-detail.component.spec.ts +++ b/experimental/traffic-portal/src/app/core/users/roles/detail/role-detail.component.spec.ts @@ -11,13 +11,13 @@ * See the License for the specific language governing permissions and * limitations under the License. */ + import { ComponentFixture, TestBed } from "@angular/core/testing"; -import { MatDialog, MatDialogModule, type MatDialogRef } from "@angular/material/dialog"; +import { MatDialogModule } from "@angular/material/dialog"; import { ActivatedRoute } from "@angular/router"; import { RouterTestingModule } from "@angular/router/testing"; -import { of, ReplaySubject } from "rxjs"; +import { ReplaySubject } from "rxjs"; -import { UserService } from "src/app/api"; import { APITestingModule } from "src/app/api/testing"; import { RoleDetailComponent } from "src/app/core/users/roles/detail/role-detail.component"; import { NavigationService } from "src/app/shared/navigation/navigation.service"; diff --git a/experimental/traffic-portal/src/app/core/users/roles/detail/role-detail.component.ts b/experimental/traffic-portal/src/app/core/users/roles/detail/role-detail.component.ts index ba81b5170f..11fed475fe 100644 --- a/experimental/traffic-portal/src/app/core/users/roles/detail/role-detail.component.ts +++ b/experimental/traffic-portal/src/app/core/users/roles/detail/role-detail.component.ts @@ -33,8 +33,8 @@ export class RoleDetailComponent implements OnInit { public new = false; public role!: ResponseRole; constructor(private readonly route: ActivatedRoute, private readonly userService: UserService, - private readonly location: Location, private readonly dialog: MatDialog, - private readonly header: NavigationService) { + private readonly location: Location, private readonly dialog: MatDialog, + private readonly header: NavigationService) { } /** diff --git a/experimental/traffic-portal/src/app/core/users/roles/table/roles-table.component.ts b/experimental/traffic-portal/src/app/core/users/roles/table/roles-table.component.ts index 5e00253cce..a59651352f 100644 --- a/experimental/traffic-portal/src/app/core/users/roles/table/roles-table.component.ts +++ b/experimental/traffic-portal/src/app/core/users/roles/table/roles-table.component.ts @@ -14,7 +14,9 @@ import { Component, type OnInit } from "@angular/core"; import { FormControl } from "@angular/forms"; -import {ActivatedRoute, type Params} from "@angular/router"; +import { MatDialog } from "@angular/material/dialog"; +import { ActivatedRoute, type Params } from "@angular/router"; + import { BehaviorSubject } from "rxjs"; import type { ResponseRole } from "trafficops-types"; @@ -23,7 +25,7 @@ import { CurrentUserService } from "src/app/shared/current-user/current-user.ser import { DecisionDialogComponent } from "src/app/shared/dialogs/decision-dialog/decision-dialog.component"; import type { ContextMenuActionEvent, ContextMenuItem } from "src/app/shared/generic-table/generic-table.component"; import { NavigationService } from "src/app/shared/navigation/navigation.service"; -import {MatDialog} from "@angular/material/dialog"; + /** * RolesTableComponent is the controller for the "Roles" table. */
