(trafficcontrol) branch master updated: fix cannot read property 'forEach' of null charts (#7847)

[ocket8888]

This is an automated email from the ASF dual-hosted git repository.

ocket8888 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficcontrol.git


The following commit(s) were added to refs/heads/master by this push:
     new 5d4db51c68 fix cannot read property 'forEach' of null charts (#7847)
5d4db51c68 is described below

commit 5d4db51c683d7faa4dbe4cce96e787530e1f5e88
Author: The Anh Nguyen <ntheanh...@gmail.com>
AuthorDate: Wed Nov 1 18:27:21 2023 +0100

    fix cannot read property 'forEach' of null charts (#7847)
---
 traffic_portal/app/src/common/modules/chart/bps/ChartBPSController.js   | 2 +-
 .../src/common/modules/chart/httpStatus/ChartHttpStatusController.js    | 2 +-
 traffic_portal/app/src/common/modules/chart/tps/ChartTPSController.js   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/traffic_portal/app/src/common/modules/chart/bps/ChartBPSController.js 
b/traffic_portal/app/src/common/modules/chart/bps/ChartBPSController.js
index 2224296aa7..159ec0ebda 100644
--- a/traffic_portal/app/src/common/modules/chart/bps/ChartBPSController.js
+++ b/traffic_portal/app/src/common/modules/chart/bps/ChartBPSController.js
@@ -79,7 +79,7 @@ var ChartBPSController = function(deliveryService, $scope, 
$timeout, $filter, $q
                var normalizedChartData = [];
 
                if (angular.isDefined(series)) {
-                       series.values.forEach(function(seriesItem) {
+                       series.values?.forEach(function(seriesItem) {
                                if (moment(seriesItem[0]).isSame(start) || 
moment(seriesItem[0]).isAfter(start)) {
                                        normalizedChartData.push([ 
moment(seriesItem[0]).valueOf(),
                                                
numberUtils.convertTo(seriesItem[1], $scope.unitSize) ]); // converts data to 
appropriate unit
diff --git 
a/traffic_portal/app/src/common/modules/chart/httpStatus/ChartHttpStatusController.js
 
b/traffic_portal/app/src/common/modules/chart/httpStatus/ChartHttpStatusController.js
index 0d308387e3..aae5ff3f64 100644
--- 
a/traffic_portal/app/src/common/modules/chart/httpStatus/ChartHttpStatusController.js
+++ 
b/traffic_portal/app/src/common/modules/chart/httpStatus/ChartHttpStatusController.js
@@ -92,7 +92,7 @@ var ChartHttpStatusController = function(deliveryService, 
$scope, $timeout, $fil
                        series = result.series;
 
                if (angular.isDefined(series)) {
-                       series.values.forEach(function(seriesItem) {
+                       series.values?.forEach(function(seriesItem) {
                                if (moment(seriesItem[0]).isSame(start) || 
moment(seriesItem[0]).isAfter(start)) {
                                        if (_.isNumber(seriesItem[1])) {
                                                normalizedChartData.push([ 
moment(seriesItem[0]).valueOf(), seriesItem[1] ]);
diff --git 
a/traffic_portal/app/src/common/modules/chart/tps/ChartTPSController.js 
b/traffic_portal/app/src/common/modules/chart/tps/ChartTPSController.js
index c2722b4fa4..02e8ccef50 100644
--- a/traffic_portal/app/src/common/modules/chart/tps/ChartTPSController.js
+++ b/traffic_portal/app/src/common/modules/chart/tps/ChartTPSController.js
@@ -78,7 +78,7 @@ var ChartTPSController = function(deliveryService, $scope, 
$timeout, $filter, $q
                var normalizedChartData = [];
 
                if (angular.isDefined(series)) {
-                       series.values.forEach(function(seriesItem) {
+                       series.values?.forEach(function(seriesItem) {
                                if (moment(seriesItem[0]).isSame(start) || 
moment(seriesItem[0]).isAfter(start)) {
                                        normalizedChartData.push([ 
moment(seriesItem[0]).valueOf(), seriesItem[1] ]);
                                }