This is an automated email from the ASF dual-hosted git repository.
ocket8888 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficcontrol.git
The following commit(s) were added to refs/heads/master by this push:
new a8c0a5de64 Fixed ProfileExportResponse struct to remove undocumented
alerts field. (#7917)
a8c0a5de64 is described below
commit a8c0a5de6449bf4200ec1ce275158bb2f2013f96
Author: Rima Shah <[email protected]>
AuthorDate: Mon Jan 22 15:09:37 2024 -0700
Fixed ProfileExportResponse struct to remove undocumented alerts field.
(#7917)
* Fixed ProfileExportResponse struct to remove undocumented alerts field.
* Updated changelog
* Fixed tests
---
CHANGELOG.md | 1 +
lib/go-tc/profiles.go | 2 --
traffic_ops/testing/api/v3/profiles_export_test.go | 2 +-
traffic_ops/testing/api/v4/profiles_export_test.go | 2 +-
traffic_ops/testing/api/v5/profiles_export_test.go | 2 +-
5 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3282d6f9a9..62895a318a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -15,6 +15,7 @@ The format is based on [Keep a
Changelog](http://keepachangelog.com/en/1.0.0/).
- Updated the CacheGroups Traffic Portal page to use a more performant
AG-Grid-based table.
### Fixed
+- [#7917](https://github.com/apache/trafficcontrol/pull/7917) *Traffic Ops*
Removed `Alerts` field from struct `ProfileExportResponse`.
- [#7918](https://github.com/apache/trafficcontrol/pull/7918) *Traffic Portal*
Fixed topology link under DS-Servers tables page
- [#7846](https://github.com/apache/trafficcontrol/pull/7846) *Traffic Portal*
Increase State character limit
diff --git a/lib/go-tc/profiles.go b/lib/go-tc/profiles.go
index fa449de5ad..8e31eed2d8 100644
--- a/lib/go-tc/profiles.go
+++ b/lib/go-tc/profiles.go
@@ -162,8 +162,6 @@ type ProfileExportResponse struct {
// Parameters associated to the profile
//
Parameters []ProfileExportImportParameterNullable `json:"parameters"`
-
- Alerts
}
// ProfileImportRequest is an object of the form used by Traffic Ops
diff --git a/traffic_ops/testing/api/v3/profiles_export_test.go
b/traffic_ops/testing/api/v3/profiles_export_test.go
index faeaa260f4..e5a70e2cb2 100644
--- a/traffic_ops/testing/api/v3/profiles_export_test.go
+++ b/traffic_ops/testing/api/v3/profiles_export_test.go
@@ -54,7 +54,7 @@ func TestProfilesExport(t *testing.T) {
t.Run(name, func(t *testing.T) {
resp, reqInf, err :=
testCase.ClientSession.ExportProfile(testCase.EndpointID())
for _, check := range
testCase.Expectations {
- check(t,
reqInf, resp, resp.Alerts, err)
+ check(t,
reqInf, resp, tc.Alerts{}, err)
}
})
}
diff --git a/traffic_ops/testing/api/v4/profiles_export_test.go
b/traffic_ops/testing/api/v4/profiles_export_test.go
index 13451189ef..8fb6925d31 100644
--- a/traffic_ops/testing/api/v4/profiles_export_test.go
+++ b/traffic_ops/testing/api/v4/profiles_export_test.go
@@ -56,7 +56,7 @@ func TestProfilesExport(t *testing.T) {
t.Run(name, func(t *testing.T) {
resp, reqInf, err :=
testCase.ClientSession.ExportProfile(testCase.EndpointID(),
testCase.RequestOpts)
for _, check := range
testCase.Expectations {
- check(t,
reqInf, resp, resp.Alerts, err)
+ check(t,
reqInf, resp, tc.Alerts{}, err)
}
})
}
diff --git a/traffic_ops/testing/api/v5/profiles_export_test.go
b/traffic_ops/testing/api/v5/profiles_export_test.go
index ab12b47046..73b24fbc3a 100644
--- a/traffic_ops/testing/api/v5/profiles_export_test.go
+++ b/traffic_ops/testing/api/v5/profiles_export_test.go
@@ -55,7 +55,7 @@ func TestProfilesExport(t *testing.T) {
t.Run(name, func(t *testing.T) {
resp, reqInf, err :=
testCase.ClientSession.ExportProfile(testCase.EndpointID(),
testCase.RequestOpts)
for _, check := range
testCase.Expectations {
- check(t,
reqInf, resp, resp.Alerts, err)
+ check(t,
reqInf, resp, tc.Alerts{}, err)
}
})
}