This is an automated email from the ASF dual-hosted git repository.

zrhoffman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficcontrol.git


The following commit(s) were added to refs/heads/master by this push:
     new 3e74b165ef Do not include Scenes dev dependencies in Traffic Stats 
(#8010)
3e74b165ef is described below

commit 3e74b165ef87270e9a285a8a0a8ed0673df2f948
Author: Zach Hoffman <[email protected]>
AuthorDate: Mon May 20 10:40:59 2024 -0600

    Do not include Scenes dev dependencies in Traffic Stats (#8010)
    
    * Do not include Scenes dev dependencies in Traffic Stats
    
    * Make some dependencies non-dev
---
 CHANGELOG.md                                     |  1 +
 traffic_stats/build/build_rpm.sh                 |  2 +-
 traffic_stats/trafficcontrol-scenes/package.json | 46 ++++++++++++------------
 3 files changed, 25 insertions(+), 24 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index d3a65b2ef9..3b8ce0cfdd 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -28,6 +28,7 @@ The format is based on [Keep a 
Changelog](http://keepachangelog.com/en/1.0.0/).
 - [#7917](https://github.com/apache/trafficcontrol/pull/7917) *Traffic Ops* 
Removed `Alerts` field from struct `ProfileExportResponse`.
 - [#7918](https://github.com/apache/trafficcontrol/pull/7918) *Traffic Portal* 
Fixed topology link under DS-Servers tables page
 - [#7846](https://github.com/apache/trafficcontrol/pull/7846) *Traffic Portal* 
Increase State character limit
+- [#8010](https://github.com/apache/trafficcontrol/pull/8010) *Traffic Stats* 
Omit NPM dev dependencies from Traffic Stats RPM
 
 ### Removed
 - [#7832](https://github.com/apache/trafficcontrol/pull/7832) *t3c* Removed 
Perl dependency
diff --git a/traffic_stats/build/build_rpm.sh b/traffic_stats/build/build_rpm.sh
index 2437e1ece4..ac72019b6e 100755
--- a/traffic_stats/build/build_rpm.sh
+++ b/traffic_stats/build/build_rpm.sh
@@ -81,7 +81,7 @@ initBuildArea() {
   # compile trafficcontrol-scenes
   echo "Installing grafana scenes npm dependencies"
   (cd trafficcontrol-scenes
-    npm i || \
+    npm i --omit=dev || \
         { echo "Could not install packages from $TS_DIR/trafficcontrol-scenes: 
$?"; return 1; }
   )
 
diff --git a/traffic_stats/trafficcontrol-scenes/package.json 
b/traffic_stats/trafficcontrol-scenes/package.json
index 0918bdafe4..ab810fa9e5 100644
--- a/traffic_stats/trafficcontrol-scenes/package.json
+++ b/traffic_stats/trafficcontrol-scenes/package.json
@@ -18,61 +18,61 @@
   "author": "ntheanh201",
   "license": "Apache-2.0",
   "devDependencies": {
-    "@babel/core": "^7.21.4",
     "@grafana/e2e": "10.0.3",
     "@grafana/e2e-selectors": "10.0.3",
-    "@grafana/eslint-config": "^6.0.0",
     "@grafana/tsconfig": "^1.2.0-rc1",
-    "@swc/core": "^1.3.90",
     "@swc/helpers": "^0.5.0",
     "@swc/jest": "^0.2.26",
     "@testing-library/jest-dom": "6.1.4",
     "@testing-library/react": "14.0.0",
     "@types/jest": "^29.5.0",
-    "@types/lodash": "^4.14.194",
     "@types/node": "^20.8.7",
-    "@types/react-router-dom": "^5.3.3",
     "@types/testing-library__jest-dom": "5.14.8",
-    "copy-webpack-plugin": "^11.0.0",
-    "css-loader": "^6.7.3",
-    "eslint-plugin-deprecation": "^2.0.0",
-    "eslint-plugin-import": "^2.29.1",
-    "eslint-plugin-prefer-arrow": "^1.2.3",
-    "eslint-webpack-plugin": "^4.0.1",
-    "fork-ts-checker-webpack-plugin": "^8.0.0",
-    "glob": "^10.2.7",
     "identity-obj-proxy": "3.0.0",
     "jest": "^29.5.0",
     "jest-environment-jsdom": "^29.5.0",
     "prettier": "^2.8.7",
-    "replace-in-file-webpack-plugin": "^1.0.6",
     "sass": "1.63.2",
-    "sass-loader": "13.3.1",
-    "style-loader": "3.3.3",
-    "swc-loader": "^0.2.3",
-    "ts-node": "^10.9.1",
     "tsconfig-paths": "^4.2.0",
-    "typescript": "4.8.4",
-    "webpack": "^5.86.0",
-    "webpack-cli": "^5.1.4",
-    "webpack-livereload-plugin": "^3.0.2"
+    "typescript": "4.8.4"
   },
   "engines": {
     "node": ">=20"
   },
   "dependencies": {
+    "@babel/core": "^7.21.4",
     "@emotion/css": "11.10.6",
     "@grafana/data": "10.0.3",
+    "@grafana/eslint-config": "^6.0.0",
     "@grafana/runtime": "10.0.3",
     "@grafana/scenes": "^1.28.0",
     "@grafana/schema": "10.0.3",
     "@grafana/ui": "10.0.3",
+    "@swc/core": "^1.3.90",
+    "@types/lodash": "^4.14.194",
+    "@types/react-router-dom": "^5.3.3",
+    "copy-webpack-plugin": "^11.0.0",
+    "css-loader": "^6.7.3",
+    "eslint-plugin-deprecation": "^2.0.0",
+    "eslint-plugin-import": "^2.29.1",
+    "eslint-plugin-prefer-arrow": "^1.2.3",
+    "eslint-webpack-plugin": "^4.0.1",
+    "fork-ts-checker-webpack-plugin": "^8.0.0",
+    "glob": "^10.2.7",
     "globby": "^14.0.0",
     "react": "18.2.0",
     "react-dom": "18.2.0",
     "react-router-dom": "5.3.3",
+    "replace-in-file-webpack-plugin": "^1.0.6",
     "rxjs": "7.8.0",
-    "tslib": "2.5.3"
+    "sass-loader": "13.3.1",
+    "style-loader": "3.3.3",
+    "swc-loader": "^0.2.3",
+    "tslib": "2.5.3",
+    "ts-node": "^10.9.1",
+    "webpack": "^5.86.0",
+    "webpack-cli": "^5.1.4",
+    "webpack-livereload-plugin": "^3.0.2"
   },
   "packageManager": "[email protected]"
 }

Reply via email to