TS-1791: remove m_mutex acquire&release to avoid deadlock
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/20c6a459 Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/20c6a459 Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/20c6a459 Branch: refs/heads/3.3.x Commit: 20c6a459fd943b9460052af427bf7a54701ae9ae Parents: 3c1e58a Author: Gang Li <[email protected]> Authored: Mon Apr 1 16:35:31 2013 +0800 Committer: Leif Hedstrom <[email protected]> Committed: Mon Apr 15 14:45:42 2013 -0600 ---------------------------------------------------------------------- CHANGES | 3 +++ proxy/logging/LogBuffer.cc | 4 +--- 2 files changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/trafficserver/blob/20c6a459/CHANGES ---------------------------------------------------------------------- diff --git a/CHANGES b/CHANGES index 8a5218a..9883ad7 100644 --- a/CHANGES +++ b/CHANGES @@ -2,6 +2,9 @@ Changes with Apache Traffic Server 3.3.2 + *) [TS-1791] remove m_mutex acquire&release to avoid deadlock in + ~LogBufferList(). Author: Gang Li <[email protected]>. + *) [TS-1713] SRV support refine. Now the srv option is able to enable, with no crash. Be care, the hostdb.storage_size or ostdb.size need check. http://git-wip-us.apache.org/repos/asf/trafficserver/blob/20c6a459/proxy/logging/LogBuffer.cc ---------------------------------------------------------------------- diff --git a/proxy/logging/LogBuffer.cc b/proxy/logging/LogBuffer.cc index 937247b..5cfab2a 100644 --- a/proxy/logging/LogBuffer.cc +++ b/proxy/logging/LogBuffer.cc @@ -764,12 +764,10 @@ LogBufferList::LogBufferList() LogBufferList::~LogBufferList() { LogBuffer *lb; - ink_mutex_acquire(&m_mutex); - m_size = 0; while ((lb = get()) != NULL) { delete lb; } - ink_mutex_release(&m_mutex); + m_size = 0; ink_mutex_destroy(&m_mutex); }
