Updated Branches: refs/heads/master 9d6707b4c -> 67a308080
TS-1475: remove dead code from SDK_API_TSHttpHdrParse Coverity CID: 1022188 Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/b75a88fb Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/b75a88fb Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/b75a88fb Branch: refs/heads/master Commit: b75a88fb0f4dcdf7e5661dad67dad9ab96863d8e Parents: 9d6707b Author: James Peach <[email protected]> Authored: Sat Jun 22 10:32:43 2013 -0700 Committer: James Peach <[email protected]> Committed: Sat Jun 22 15:54:04 2013 -0700 ---------------------------------------------------------------------- proxy/InkAPITest.cc | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/trafficserver/blob/b75a88fb/proxy/InkAPITest.cc ---------------------------------------------------------------------- diff --git a/proxy/InkAPITest.cc b/proxy/InkAPITest.cc index a1cdf8e..8705ffa 100644 --- a/proxy/InkAPITest.cc +++ b/proxy/InkAPITest.cc @@ -4522,8 +4522,6 @@ REGRESSION_TEST(SDK_API_TSHttpHdrParse) (RegressionTest * test, int atype, int * bool test_passed_parse_resp = false; bool test_passed_parser_clear = false; bool test_passed_parser_destroy = false; - bool resp_run = true; - //Create Parser parser = TSHttpParserCreate(); @@ -4564,8 +4562,6 @@ REGRESSION_TEST(SDK_API_TSHttpHdrParse) (RegressionTest * test, int atype, int * SDK_RPRINT(test, "TSHttpHdrParseResp", "TestCase1", TC_FAIL, "Parsing Error"); } } - } else { - resp_run = false; } if (test_passed_parse_req == true) { @@ -4602,16 +4598,17 @@ REGRESSION_TEST(SDK_API_TSHttpHdrParse) (RegressionTest * test, int atype, int * } TSMimeHdrDestroy(reqbufp, req_hdr_loc); - if (resp_run == true) - TSMimeHdrDestroy(respbufp, resp_hdr_loc); - TSHandleMLocRelease(reqbufp, TS_NULL_MLOC, req_hdr_loc); - if (resp_run == true) + TSMBufferDestroy(reqbufp); + + if (resp_hdr_loc) { + TSMimeHdrDestroy(respbufp, resp_hdr_loc); TSHandleMLocRelease(respbufp, TS_NULL_MLOC, resp_hdr_loc); + } - TSMBufferDestroy(reqbufp); - if (resp_run == true) + if (respbufp) { TSMBufferDestroy(respbufp); + } return; }
