TS-2467: traffic_shell doesn't work with tcl 8.6, works with 8.5

Segfault in libtcl8.6.so when calling Tcl_SetMainLoop(Tcl_ReadlineMain).
If setting Tcl MainLoop, we should call Tcl_FindExecutable(NULL),
which fixes TCL 8.6 and should also work with older versions.

Conflicts:
        CHANGES


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/a9a7ba63
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/a9a7ba63
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/a9a7ba63

Branch: refs/heads/4.1.x
Commit: a9a7ba63982401cc303d8a4e4b3ffc1e49239f1a
Parents: a40d119
Author: Ben Aitchison <[email protected]>
Authored: Thu Jan 2 15:37:40 2014 -0800
Committer: Igor Galić <[email protected]>
Committed: Tue Feb 4 14:27:14 2014 +0100

----------------------------------------------------------------------
 CHANGES             | 3 +++
 mgmt/cli/cliMain.cc | 2 ++
 2 files changed, 5 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a9a7ba63/CHANGES
----------------------------------------------------------------------
diff --git a/CHANGES b/CHANGES
index b15e219..6b85437 100644
--- a/CHANGES
+++ b/CHANGES
@@ -3,6 +3,9 @@ Changes with Apache Traffic Server 4.1.3
 
   *) [TS-2305] Fall back to ftruncate if posix_fallocate fails.
 
+  *) [TS-2467] traffic_shell doesn't work with tcl 8.6.
+   Author: Ben Aitchison <[email protected]>
+
   *) [TS-2469] remove libreadline which is gpl licensed.
    Author: Ben Aitchison <[email protected]>
 

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a9a7ba63/mgmt/cli/cliMain.cc
----------------------------------------------------------------------
diff --git a/mgmt/cli/cliMain.cc b/mgmt/cli/cliMain.cc
index 8da720a..29978c7 100644
--- a/mgmt/cli/cliMain.cc
+++ b/mgmt/cli/cliMain.cc
@@ -73,6 +73,8 @@ main(int argc, char *argv[])
     exit(0);
   }
 
+  Tcl_FindExecutable(argv[0]);
+
   // traffic_shell binary should use printf to display information onscreen
   CliDisplayPrintf = 1;
 

Reply via email to