On Jun 9, 2014, at 5:35 AM, Alan M. Carroll <[email protected]> wrote:
> James, > > >> The correct syntax for referring to function arguments is :c:arg:`foo` > > Except sockaddr in this case is not a functiona argument, it is a type. The > argument is "addr". Ah, good point. > >> :data:`NULL` > > WARNING: py:data reference target not found: NULL Weird, that's used in other places. Does :c:data:`NULL` generate an error too? > > I would argue against using constructs that generate errors. We could use > :literal:`NULL` but that's synonymous with ``NULL``. > > The real problem here is the lack of :c:const: and support for enums. We'll > have to fix that someday. > > >> Well, there is not SPDY plugin, and there is no code that actually uses >> TSHttpConnectWithPluginId, > > It is used in proxy/FetchSM.cc. Well, that's not a plugin ;) SPDY never makes the call directly; it happens implicitly since SpdyClientSession is both a continuation and a PluginIdentity. That trick is not available to plugins. >> We invariably close with a See also section, which should at least refer to >> :manpage:`TSAPI(3ts)` > > Not quite invariably - see TSHttpConnect. I'll fix it anyway. thanks!
