Repository: trafficserver Updated Branches: refs/heads/master 84ca4de2e -> a41b3b520
TS-1475: Fix use after free in cache-scan plugin. Coverity #1021658 Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/a41b3b52 Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/a41b3b52 Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/a41b3b52 Branch: refs/heads/master Commit: a41b3b520ea2122f78d6a2b051807e36cd09ab76 Parents: 84ca4de Author: Brian Geffon <[email protected]> Authored: Mon Jul 14 14:34:18 2014 -0700 Committer: Brian Geffon <[email protected]> Committed: Mon Jul 14 14:34:18 2014 -0700 ---------------------------------------------------------------------- example/cache-scan/cache-scan.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a41b3b52/example/cache-scan/cache-scan.cc ---------------------------------------------------------------------- diff --git a/example/cache-scan/cache-scan.cc b/example/cache-scan/cache-scan.cc index efde358..4a5e500 100644 --- a/example/cache-scan/cache-scan.cc +++ b/example/cache-scan/cache-scan.cc @@ -449,9 +449,9 @@ setup_request(TSCont contp, TSHttpTxn txnp) if (TSUrlParse(urlBuf, urlLoc, (const char **) &start, end) != TS_PARSE_DONE || TSCacheKeyDigestFromUrlSet(cstate->key_to_delete, urlLoc) != TS_SUCCESS) { TSError("CacheKeyDigestFromUrlSet failed"); + TSCacheKeyDestroy(cstate->key_to_delete); TSfree(cstate); TSHandleMLocRelease(urlBuf, NULL, urlLoc); - TSCacheKeyDestroy(cstate->key_to_delete); goto Ldone; } TSHandleMLocRelease(urlBuf, NULL, urlLoc);
