Repository: trafficserver Updated Branches: refs/heads/master 57b33ae8b -> 49a2c805a
TS-3303 tcpinfo: we can close the log file object multiple times Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/49a2c805 Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/49a2c805 Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/49a2c805 Branch: refs/heads/master Commit: 49a2c805ac0d5032de9c1fb35766e49bb18960e8 Parents: 18be1cf Author: Leif Hedstrom <[email protected]> Authored: Thu Jan 15 18:29:26 2015 -0700 Committer: Leif Hedstrom <[email protected]> Committed: Thu Jan 15 18:29:29 2015 -0700 ---------------------------------------------------------------------- CHANGES | 2 ++ plugins/tcpinfo/tcpinfo.cc | 7 ++----- 2 files changed, 4 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/trafficserver/blob/49a2c805/CHANGES ---------------------------------------------------------------------- diff --git a/CHANGES b/CHANGES index a005672..a587946 100644 --- a/CHANGES +++ b/CHANGES @@ -1,6 +1,8 @@ -*- coding: utf-8 -*- Changes with Apache Traffic Server 5.3.0 + *) [TS-3303] tcpinfo: we can close the log file object multiple times. + *) [TS-3297] Begin encapsulating parse errors in an error object. *) [TS-3296] Use Regex.h to find PCRE headers. http://git-wip-us.apache.org/repos/asf/trafficserver/blob/49a2c805/plugins/tcpinfo/tcpinfo.cc ---------------------------------------------------------------------- diff --git a/plugins/tcpinfo/tcpinfo.cc b/plugins/tcpinfo/tcpinfo.cc index 481f553..1937eed 100644 --- a/plugins/tcpinfo/tcpinfo.cc +++ b/plugins/tcpinfo/tcpinfo.cc @@ -171,12 +171,9 @@ log_tcp_info(Config * config, const char * event_name, TSHttpSsn ssnp) info.tcpi_rtt); } - // It's really not clear how we should handle logging failures. It a failure transient - // or persistent? Should we try to re-open the logs? How frequently should we do that? if (ret != TS_SUCCESS) { - TSError("[tcpinfo] log write failed, disabling logging"); - TSTextLogObjectDestroy(config->log); - config->log = NULL; + // ToDo: This could be due to a failure, or logs full. Should we consider + // closing / reopening the log? If so, how often do we do that ? } }
