Repository: trafficserver
Updated Branches:
  refs/heads/master 0296285e6 -> 2c2a5155c


TS-3287: Remove superfluous NULL check

Coverity CID #1267803


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/2c2a5155
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/2c2a5155
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/2c2a5155

Branch: refs/heads/master
Commit: 2c2a5155cb46051a57935464277ebbbed2dbaefb
Parents: 0296285
Author: Phil Sorber <[email protected]>
Authored: Wed Feb 4 18:59:20 2015 -0700
Committer: Phil Sorber <[email protected]>
Committed: Wed Feb 4 18:59:20 2015 -0700

----------------------------------------------------------------------
 plugins/experimental/url_sig/url_sig.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/2c2a5155/plugins/experimental/url_sig/url_sig.c
----------------------------------------------------------------------
diff --git a/plugins/experimental/url_sig/url_sig.c 
b/plugins/experimental/url_sig/url_sig.c
index d0023fb..bd24987 100644
--- a/plugins/experimental/url_sig/url_sig.c
+++ b/plugins/experimental/url_sig/url_sig.c
@@ -434,8 +434,7 @@ TSRemapDoRemap(void *ih, TSHttpTxn txnp, TSRemapRequestInfo 
* rri)
 
   /* ********* Deny ********* */
 deny:
-  if (url)
-    TSfree(url);
+  TSfree(url);
 
   switch (cfg->err_status) {
   case TS_HTTP_STATUS_MOVED_TEMPORARILY:
@@ -459,8 +458,8 @@ deny:
   return TSREMAP_DID_REMAP;
 
   /* ********* Allow ********* */
-allow:if (url)
-    TSfree(url);
+allow:
+  TSfree(url);
   /* drop the query string so we can cache-hit */
   rval = TSUrlHttpQuerySet(rri->requestBufp, rri->requestUrl, NULL, 0);
   if (rval != TS_SUCCESS) {

Reply via email to