Repository: trafficserver Updated Branches: refs/heads/master a01dc03af -> 1678555d0
TS-3176: some DNS stats don't persist through restart Over time when viewing stats through traffic_top the "DNS lookup" stat will happily persist through a restart but at the very least "DNS hits" and the "DNS Hit" percentage will not. Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/1678555d Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/1678555d Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/1678555d Branch: refs/heads/master Commit: 1678555d09c283768611a51bf7b3395a8d589de5 Parents: a01dc03 Author: Adam W. Dace <[email protected]> Authored: Mon Mar 9 15:19:57 2015 -0700 Committer: James Peach <[email protected]> Committed: Mon Mar 9 15:21:18 2015 -0700 ---------------------------------------------------------------------- CHANGES | 3 +++ cmd/traffic_top/stats.h | 6 +++--- cmd/traffic_top/traffic_top.cc | 2 +- iocore/hostdb/HostDB.cc | 2 +- 4 files changed, 8 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/trafficserver/blob/1678555d/CHANGES ---------------------------------------------------------------------- diff --git a/CHANGES b/CHANGES index ee6f0ca..1a524a9 100644 --- a/CHANGES +++ b/CHANGES @@ -1,6 +1,9 @@ -*- coding: utf-8 -*- Changes with Apache Traffic Server 5.3.0 + *) [TS-3176] Some DNS stats don't persist through restart. + Author: Adam W. Dace <[email protected]> + *) [TS-3211] Add support for modifying the SCHEME via the header_rewrite plugin. Original author: Scott Beardsley. http://git-wip-us.apache.org/repos/asf/trafficserver/blob/1678555d/cmd/traffic_top/stats.h ---------------------------------------------------------------------- diff --git a/cmd/traffic_top/stats.h b/cmd/traffic_top/stats.h index 06ab653..714781b 100644 --- a/cmd/traffic_top/stats.h +++ b/cmd/traffic_top/stats.h @@ -97,9 +97,9 @@ public: lookup_table.insert(make_pair("entries", LookupItem("Entries", "proxy.process.cache.direntries.used", 1))); lookup_table.insert(make_pair("avg_size", LookupItem("Avg Size", "disk_used", "entries", 3))); - lookup_table.insert(make_pair("dns_time", LookupItem("DNS Time", "proxy.node.dns.lookup_avg_time_ms", 2))); - lookup_table.insert(make_pair("dns_hits", LookupItem("DNS hits", "proxy.node.hostdb.total_hits", 2))); - lookup_table.insert(make_pair("dns_lookups", LookupItem("DNS lookups", "proxy.node.hostdb.total_lookups", 2))); + lookup_table.insert(make_pair("dns_entry", LookupItem("DNS Entry", "proxy.process.hostdb.total_entries", 1))); + lookup_table.insert(make_pair("dns_hits", LookupItem("DNS Hits", "proxy.process.hostdb.total_hits", 2))); + lookup_table.insert(make_pair("dns_lookups", LookupItem("DNS Lookups", "proxy.process.hostdb.total_lookups", 2))); lookup_table.insert(make_pair("client_req", LookupItem("Requests", "proxy.process.http.incoming_requests", 2))); lookup_table.insert(make_pair("client_conn", LookupItem("New Conn", "proxy.process.http.total_client_connections", 2))); lookup_table.insert(make_pair("client_req_conn", LookupItem("Req/Conn", "client_req", "client_conn", 3))); http://git-wip-us.apache.org/repos/asf/trafficserver/blob/1678555d/cmd/traffic_top/traffic_top.cc ---------------------------------------------------------------------- diff --git a/cmd/traffic_top/traffic_top.cc b/cmd/traffic_top/traffic_top.cc index 2a138d5..71d8729 100644 --- a/cmd/traffic_top/traffic_top.cc +++ b/cmd/traffic_top/traffic_top.cc @@ -298,7 +298,7 @@ void main_stats_page(Stats &stats) cache2.push_back("not_time"); cache2.push_back("no_time"); cache2.push_back("dns_ratio"); - cache2.push_back("dns_time"); + cache2.push_back("dns_entry"); makeTable(21, 1, cache2, stats); list<string> response1; http://git-wip-us.apache.org/repos/asf/trafficserver/blob/1678555d/iocore/hostdb/HostDB.cc ---------------------------------------------------------------------- diff --git a/iocore/hostdb/HostDB.cc b/iocore/hostdb/HostDB.cc index 74f13bc..3f4a0cf 100644 --- a/iocore/hostdb/HostDB.cc +++ b/iocore/hostdb/HostDB.cc @@ -2493,7 +2493,7 @@ ink_hostdb_init(ModuleVersion v) RecRegisterRawStat(hostdb_rsb, RECT_PROCESS, "proxy.process.hostdb.total_hits", - RECD_INT, RECP_NON_PERSISTENT, (int) hostdb_total_hits_stat, RecRawStatSyncSum); + RECD_INT, RECP_PERSISTENT, (int) hostdb_total_hits_stat, RecRawStatSyncSum); RecRegisterRawStat(hostdb_rsb, RECT_PROCESS, "proxy.process.hostdb.ttl", RECD_FLOAT, RECP_PERSISTENT, (int) hostdb_ttl_stat, RecRawStatSyncAvg);
