This is an automated email from the ASF dual-hosted git repository.
jacksontj pushed a commit to branch master
in repository https://git-dual.apache.org/repos/asf/trafficserver.git
The following commit(s) were added to refs/heads/master by this push:
new ef57dfa TS-4674: Remove useless assert statement (#809)
ef57dfa is described below
commit ef57dfadfd2708e105d5239728bfe4dbbaa36b15
Author: Thomas Jackson <[email protected]>
AuthorDate: Tue Jul 19 08:56:18 2016 -0700
TS-4674: Remove useless assert statement (#809)
Now that we have clean allocations (instead of clobbering existing things)
there is no need to have this assertion. In practice this assertion is actually
incorrect, because in the case where we want to extend the lifetime of a stale
record (since the response we got was broken) we'll fail this assert.
This closes #809
---
iocore/hostdb/HostDB.cc | 3 ---
1 file changed, 3 deletions(-)
diff --git a/iocore/hostdb/HostDB.cc b/iocore/hostdb/HostDB.cc
index 26810d9..b12f20c 100644
--- a/iocore/hostdb/HostDB.cc
+++ b/iocore/hostdb/HostDB.cc
@@ -1332,9 +1332,6 @@ HostDBContinuation::dnsEvent(int event, HostEnt *e)
r = lookup_done(md5.ip, e->ent.h_name, false, ttl_seconds,
&e->srv_hosts, r);
}
- // @c lookup_done should always return a valid value so @a r should be
null @c NULL.
- ink_assert(r && r->app.allotment.application1 == 0 &&
r->app.allotment.application2 == 0);
-
// Conditionally make rr record entries
if (is_rr) {
r->app.rr.offset = offset;
--
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].
