This is an automated email from the ASF dual-hosted git repository. zwoop pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/trafficserver.git
commit 5b730441e9dc89504f5b25ff7bfdb58d4da0aa29 Author: Phil Sorber <[email protected]> AuthorDate: Thu May 11 13:43:27 2017 -0600 Coverity CID #1022120 Dereference before null check --- iocore/dns/SplitDNS.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/iocore/dns/SplitDNS.cc b/iocore/dns/SplitDNS.cc index 9bd69f0..096bfb3 100644 --- a/iocore/dns/SplitDNS.cc +++ b/iocore/dns/SplitDNS.cc @@ -138,13 +138,13 @@ SplitDNSConfig::reconfigure() params->m_SplitDNSlEnable = gsplit_dns_enabled; params->m_DNSSrvrTable = new DNS_table("proxy.config.dns.splitdns.filename", modulePrefix, &sdns_dest_tags); - params->m_numEle = params->m_DNSSrvrTable->getEntryCount(); - if (nullptr == params->m_DNSSrvrTable || (0 == params->m_numEle)) { + if (nullptr == params->m_DNSSrvrTable || (0 == params->m_DNSSrvrTable->getEntryCount())) { Warning("No NAMEDs provided! Disabling SplitDNS"); gsplit_dns_enabled = 0; delete params; return; } + params->m_numEle = params->m_DNSSrvrTable->getEntryCount(); if (nullptr != params->m_DNSSrvrTable->getHostMatcher() && nullptr == params->m_DNSSrvrTable->getReMatcher() && nullptr == params->m_DNSSrvrTable->getIPMatcher() && 4 >= params->m_numEle) { -- To stop receiving notification emails like this one, please contact "[email protected]" <[email protected]>.
