This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 04f8a18  Coverity 1021734 Uninitialized pointer field
04f8a18 is described below

commit 04f8a187e14ae0a3191f464de359967b46632480
Author: Leif Hedstrom <[email protected]>
AuthorDate: Mon Jun 5 09:01:39 2017 -0600

    Coverity 1021734 Uninitialized pointer field
---
 iocore/utils/I_OneWayMultiTunnel.h | 6 +++---
 iocore/utils/OneWayMultiTunnel.cc  | 3 ++-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/iocore/utils/I_OneWayMultiTunnel.h 
b/iocore/utils/I_OneWayMultiTunnel.h
index 0189cc4..7997549 100644
--- a/iocore/utils/I_OneWayMultiTunnel.h
+++ b/iocore/utils/I_OneWayMultiTunnel.h
@@ -142,10 +142,10 @@ struct OneWayMultiTunnel : public OneWayTunnel {
   virtual void reenable_all();
   virtual void close_target_vio(int result, VIO *vio = nullptr);
 
-  int n_vioTargets;
-  VIO *vioTargets[ONE_WAY_MULTI_TUNNEL_LIMIT];
+  int n_vioTargets                      = 0;
+  bool source_read_previously_completed = false;
   MIOBufferAccessor topOutBuffer;
-  bool source_read_previously_completed;
+  VIO *vioTargets[ONE_WAY_MULTI_TUNNEL_LIMIT];
 };
 
 extern ClassAllocator<OneWayMultiTunnel> OneWayMultiTunnelAllocator;
diff --git a/iocore/utils/OneWayMultiTunnel.cc 
b/iocore/utils/OneWayMultiTunnel.cc
index 428d345..d7be424 100644
--- a/iocore/utils/OneWayMultiTunnel.cc
+++ b/iocore/utils/OneWayMultiTunnel.cc
@@ -39,8 +39,9 @@
 
 ClassAllocator<OneWayMultiTunnel> 
OneWayMultiTunnelAllocator("OneWayMultiTunnelAllocator");
 
-OneWayMultiTunnel::OneWayMultiTunnel() : OneWayTunnel(), n_vioTargets(0), 
source_read_previously_completed(false)
+OneWayMultiTunnel::OneWayMultiTunnel() : OneWayTunnel()
 {
+  ink_zero(vioTargets);
 }
 
 OneWayMultiTunnel *

-- 
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].

Reply via email to