This is an automated email from the ASF dual-hosted git repository. masaori pushed a commit to branch quic-latest in repository https://gitbox.apache.org/repos/asf/trafficserver.git
commit 13e1e43c4c2ae8f70878fbbc64fc65188b8981f6 Author: Masaori Koshiba <[email protected]> AuthorDate: Fri Aug 25 14:10:34 2017 +0900 Ran clan-tody with performance-unnecessary-value-param --- iocore/net/quic/QUICHandshake.cc | 4 +++- iocore/net/quic/QUICLossDetector.cc | 2 +- iocore/net/quic/QUICLossDetector.h | 2 +- iocore/net/quic/QUICStream.cc | 6 +++--- iocore/net/quic/QUICStream.h | 6 +++--- iocore/net/quic/QUICStreamManager.cc | 12 ++++++------ iocore/net/quic/QUICStreamManager.h | 12 ++++++------ 7 files changed, 23 insertions(+), 21 deletions(-) diff --git a/iocore/net/quic/QUICHandshake.cc b/iocore/net/quic/QUICHandshake.cc index 9e8fdfd..521467b 100644 --- a/iocore/net/quic/QUICHandshake.cc +++ b/iocore/net/quic/QUICHandshake.cc @@ -23,6 +23,8 @@ #include "QUICGlobals.h" #include "QUICHandshake.h" + +#include <utility> #include "QUICVersionNegotiator.h" #include "QUICConfig.h" #include "P_SSLNextProtocolSet.h" @@ -126,7 +128,7 @@ QUICHandshake::negotiated_application_name(const uint8_t **name, unsigned int *l void QUICHandshake::set_transport_parameters(std::shared_ptr<QUICTransportParameters> tp) { - this->_remote_transport_parameters = tp; + this->_remote_transport_parameters = std::move(tp); const QUICTransportParametersInClientHello *tp_in_ch = dynamic_cast<const QUICTransportParametersInClientHello *>(this->_remote_transport_parameters.get()); diff --git a/iocore/net/quic/QUICLossDetector.cc b/iocore/net/quic/QUICLossDetector.cc index c406b9b..3687884 100644 --- a/iocore/net/quic/QUICLossDetector.cc +++ b/iocore/net/quic/QUICLossDetector.cc @@ -174,7 +174,7 @@ QUICLossDetector::_on_packet_sent(QUICPacketNumber packet_number, bool is_retran } void -QUICLossDetector::_on_ack_received(std::shared_ptr<const QUICAckFrame> ack_frame) +QUICLossDetector::_on_ack_received(const std::shared_ptr<const QUICAckFrame>& ack_frame) { SCOPED_MUTEX_LOCK(lock, this->mutex, this_ethread()); // If the largest acked is newly acked, update the RTT. diff --git a/iocore/net/quic/QUICLossDetector.h b/iocore/net/quic/QUICLossDetector.h index df29ac9..49d0333 100644 --- a/iocore/net/quic/QUICLossDetector.h +++ b/iocore/net/quic/QUICLossDetector.h @@ -95,7 +95,7 @@ private: void _on_packet_sent(QUICPacketNumber packet_number, bool is_retransmittable, bool is_handshake, size_t sent_bytes, std::unique_ptr<const QUICPacket> packet); - void _on_ack_received(std::shared_ptr<const QUICAckFrame> ack_frame); + void _on_ack_received(const std::shared_ptr<const QUICAckFrame>& ack_frame); void _on_packet_acked(QUICPacketNumber acked_packet_number); void _update_rtt(uint32_t latest_rtt); void _detect_lost_packets(QUICPacketNumber largest_acked); diff --git a/iocore/net/quic/QUICStream.cc b/iocore/net/quic/QUICStream.cc index f559419..c7e4626 100644 --- a/iocore/net/quic/QUICStream.cc +++ b/iocore/net/quic/QUICStream.cc @@ -237,7 +237,7 @@ QUICStream::_signal_write_event(bool direct) } void -QUICStream::_write_to_read_vio(std::shared_ptr<const QUICStreamFrame> frame) +QUICStream::_write_to_read_vio(const std::shared_ptr<const QUICStreamFrame>& frame) { SCOPED_MUTEX_LOCK(lock, this->_read_vio.mutex, this_ethread()); @@ -297,14 +297,14 @@ QUICStream::recv(std::shared_ptr<const QUICStreamFrame> frame) } QUICError -QUICStream::recv(std::shared_ptr<const QUICMaxStreamDataFrame> frame) +QUICStream::recv(const std::shared_ptr<const QUICMaxStreamDataFrame>& frame) { this->_send_max_stream_data += frame->maximum_stream_data(); return QUICError(QUICErrorClass::NONE); } QUICError -QUICStream::recv(std::shared_ptr<const QUICStreamBlockedFrame> frame) +QUICStream::recv(const std::shared_ptr<const QUICStreamBlockedFrame>& frame) { this->_slide_recv_max_stream_data(); return QUICError(QUICErrorClass::NONE); diff --git a/iocore/net/quic/QUICStream.h b/iocore/net/quic/QUICStream.h index dfcb2c6..8d54eda 100644 --- a/iocore/net/quic/QUICStream.h +++ b/iocore/net/quic/QUICStream.h @@ -60,8 +60,8 @@ public: void reenable(VIO *vio) override; QUICError recv(std::shared_ptr<const QUICStreamFrame> frame); - QUICError recv(std::shared_ptr<const QUICMaxStreamDataFrame> frame); - QUICError recv(std::shared_ptr<const QUICStreamBlockedFrame> frame); + QUICError recv(const std::shared_ptr<const QUICMaxStreamDataFrame>& frame); + QUICError recv(const std::shared_ptr<const QUICStreamBlockedFrame>& frame); void reset(); @@ -74,7 +74,7 @@ private: void _send(); - void _write_to_read_vio(std::shared_ptr<const QUICStreamFrame>); + void _write_to_read_vio(const std::shared_ptr<const QUICStreamFrame>&); void _reorder_data(); // NOTE: Those are called update_read_request/update_write_request in Http2Stream // void _read_from_net(uint64_t read_len, bool direct); diff --git a/iocore/net/quic/QUICStreamManager.cc b/iocore/net/quic/QUICStreamManager.cc index 0fdb968..d9a8610 100644 --- a/iocore/net/quic/QUICStreamManager.cc +++ b/iocore/net/quic/QUICStreamManager.cc @@ -44,8 +44,8 @@ QUICStreamManager::interests() } void -QUICStreamManager::init_flow_control_params(std::shared_ptr<const QUICTransportParameters> local_tp, - std::shared_ptr<const QUICTransportParameters> remote_tp) +QUICStreamManager::init_flow_control_params(const std::shared_ptr<const QUICTransportParameters>& local_tp, + const std::shared_ptr<const QUICTransportParameters>& remote_tp) { this->_local_tp = local_tp; this->_remote_tp = remote_tp; @@ -94,7 +94,7 @@ QUICStreamManager::handle_frame(std::shared_ptr<const QUICFrame> frame) } QUICError -QUICStreamManager::_handle_frame(std::shared_ptr<const QUICMaxDataFrame> frame) +QUICStreamManager::_handle_frame(const std::shared_ptr<const QUICMaxDataFrame>& frame) { this->_send_max_data = frame->maximum_data(); return QUICError(QUICErrorClass::NONE); @@ -109,7 +109,7 @@ QUICStreamManager::slide_recv_max_data() } QUICError -QUICStreamManager::_handle_frame(std::shared_ptr<const QUICMaxStreamDataFrame> frame) +QUICStreamManager::_handle_frame(const std::shared_ptr<const QUICMaxStreamDataFrame>& frame) { QUICStream *stream = this->_find_stream(frame->stream_id()); if (stream) { @@ -122,7 +122,7 @@ QUICStreamManager::_handle_frame(std::shared_ptr<const QUICMaxStreamDataFrame> f } QUICError -QUICStreamManager::_handle_frame(std::shared_ptr<const QUICStreamBlockedFrame> frame) +QUICStreamManager::_handle_frame(const std::shared_ptr<const QUICStreamBlockedFrame>& frame) { QUICStream *stream = this->_find_stream(frame->stream_id()); if (stream) { @@ -135,7 +135,7 @@ QUICStreamManager::_handle_frame(std::shared_ptr<const QUICStreamBlockedFrame> f } QUICError -QUICStreamManager::_handle_frame(std::shared_ptr<const QUICStreamFrame> frame) +QUICStreamManager::_handle_frame(const std::shared_ptr<const QUICStreamFrame>& frame) { QUICStream *stream = this->_find_or_create_stream(frame->stream_id()); QUICApplication *application = this->_app_map->get(frame->stream_id()); diff --git a/iocore/net/quic/QUICStreamManager.h b/iocore/net/quic/QUICStreamManager.h index 17b44b4..b01dbdd 100644 --- a/iocore/net/quic/QUICStreamManager.h +++ b/iocore/net/quic/QUICStreamManager.h @@ -45,8 +45,8 @@ public: virtual bool is_recv_avail_more_than(uint64_t size); void add_recv_total_offset(uint64_t delta); void slide_recv_max_data(); - void init_flow_control_params(std::shared_ptr<const QUICTransportParameters> local_tp, - std::shared_ptr<const QUICTransportParameters> remote_tp); + void init_flow_control_params(const std::shared_ptr<const QUICTransportParameters>& local_tp, + const std::shared_ptr<const QUICTransportParameters>& remote_tp); uint64_t recv_max_data() const; uint64_t send_max_data() const; uint64_t recv_total_offset() const; @@ -57,10 +57,10 @@ public: private: QUICStream *_find_or_create_stream(QUICStreamId stream_id); QUICStream *_find_stream(QUICStreamId id); - QUICError _handle_frame(std::shared_ptr<const QUICMaxDataFrame>); - QUICError _handle_frame(std::shared_ptr<const QUICStreamFrame>); - QUICError _handle_frame(std::shared_ptr<const QUICMaxStreamDataFrame>); - QUICError _handle_frame(std::shared_ptr<const QUICStreamBlockedFrame>); + QUICError _handle_frame(const std::shared_ptr<const QUICMaxDataFrame>&); + QUICError _handle_frame(const std::shared_ptr<const QUICStreamFrame>&); + QUICError _handle_frame(const std::shared_ptr<const QUICMaxStreamDataFrame>&); + QUICError _handle_frame(const std::shared_ptr<const QUICStreamBlockedFrame>&); QUICFrameTransmitter *_tx = nullptr; QUICApplicationMap *_app_map = nullptr; -- To stop receiving notification emails like this one, please contact "[email protected]" <[email protected]>.
