This is an automated email from the ASF dual-hosted git repository.

amc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 644b456  Remove MIOBufferWriter unit tests that throw exceptions.
644b456 is described below

commit 644b456d9c888af95528a0cdef753e78d8580b35
Author: Walt Karas <wka...@yahoo-inc.com>
AuthorDate: Wed Nov 1 00:04:22 2017 +0000

    Remove MIOBufferWriter unit tests that throw exceptions.
---
 .../eventsystem/unit-tests/test_MIOBufferWriter.cc | 24 ++--------------------
 1 file changed, 2 insertions(+), 22 deletions(-)

diff --git a/iocore/eventsystem/unit-tests/test_MIOBufferWriter.cc 
b/iocore/eventsystem/unit-tests/test_MIOBufferWriter.cc
index 5665359..34a4084 100644
--- a/iocore/eventsystem/unit-tests/test_MIOBufferWriter.cc
+++ b/iocore/eventsystem/unit-tests/test_MIOBufferWriter.cc
@@ -25,6 +25,7 @@
 #include "catch.hpp"
 
 #include <cstdint>
+#include <cstdlib>
 
 struct IOBufferBlock {
   std::int64_t write_avail();
@@ -187,31 +188,10 @@ TEST_CASE("MIOBufferWriter", "[MIOBW]")
   writeOnce(bw, 1);
 
   REQUIRE(bw.extent() == ((iobbIdx * BlockSize) + blockUsed));
-
-// These tests don't work properly with clang for some reason.
-#if !defined(__clang__)
-
-  try {
-    bw.write(bw.auxBufferCapacity() + 1);
-    REQUIRE(false);
-
-  } catch (InkAssertExcept) {
-    REQUIRE(true);
-  }
-
-  try {
-    bw.data();
-    REQUIRE(false);
-
-  } catch (InkAssertExcept) {
-    REQUIRE(true);
-  }
-
-#endif
 }
 
 void
 _ink_assert(const char *a, const char *f, int l)
 {
-  throw InkAssertExcept();
+  std::exit(1);
 }

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <commits@trafficserver.apache.org>'].

Reply via email to