This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch 8.0.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/8.0.x by this push:
     new ad2581b  Allows unknown configuration variables when specified on the 
commandline
ad2581b is described below

commit ad2581b2b41a3ca3db721e8216223cfa02f88079
Author: Randall Meyer <[email protected]>
AuthorDate: Thu Oct 11 16:08:36 2018 -0700

    Allows unknown configuration variables when specified on the commandline
    
    It will still generate an error, but will not stop configuration
    
    This makes conf_remap more consistent with itself and records.config
    
    (cherry picked from commit b4241b99d0d6017397acf92a2562898b7b5e57b4)
---
 plugins/conf_remap/conf_remap.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/plugins/conf_remap/conf_remap.cc b/plugins/conf_remap/conf_remap.cc
index a821ba7..4411f89 100644
--- a/plugins/conf_remap/conf_remap.cc
+++ b/plugins/conf_remap/conf_remap.cc
@@ -79,7 +79,7 @@ RemapConfigs::parse_inline(const char *arg)
   TSOverridableConfigKey name;
   TSRecordDataType type;
 
-  // Each token should be a status code then a URL, separated by '='.
+  // Each token should be a configuration variable then a value, separated by 
'='.
   sep = strchr(arg, '=');
   if (sep == nullptr) {
     return false;
@@ -90,7 +90,7 @@ RemapConfigs::parse_inline(const char *arg)
 
   if (TSHttpTxnConfigFind(key.c_str(), -1 /* len */, &name, &type) != 
TS_SUCCESS) {
     TSError("[%s] Invalid configuration variable '%s'", PLUGIN_NAME, 
key.c_str());
-    return false;
+    return true;
   }
 
   switch (type) {

Reply via email to