This is an automated email from the ASF dual-hosted git repository. bcall pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/trafficserver.git
The following commit(s) were added to refs/heads/master by this push: new acf3297 Remove the APIHooks::invoke() function. acf3297 is described below commit acf3297e3eb8dffd0b71b53a756d73bc76157f8f Author: Walter Karas <wka...@oath.com> AuthorDate: Thu Dec 13 15:44:01 2018 -0600 Remove the APIHooks::invoke() function. In general, it is bad to have functions that are not used, and for which there is no clear potential use. This one is particularly bad. It creates the false impression that there is a possibility of simultaneous execution of continuations that are attached to the same hook (prior to calling the reenable function). --- proxy/InkAPIInternal.h | 8 -------- 1 file changed, 8 deletions(-) diff --git a/proxy/InkAPIInternal.h b/proxy/InkAPIInternal.h index c2bd1a8..cd75d64 100644 --- a/proxy/InkAPIInternal.h +++ b/proxy/InkAPIInternal.h @@ -135,7 +135,6 @@ public: APIHook *get() const; void clear(); bool is_empty() const; - void invoke(int event, void *data); private: Que(APIHook, m_link) m_hooks; @@ -147,13 +146,6 @@ APIHooks::is_empty() const return nullptr == m_hooks.head; } -inline void -APIHooks::invoke(int event, void *data) -{ - for (APIHook *hook = m_hooks.head; nullptr != hook; hook = hook->next()) - hook->invoke(event, data); -} - /** Container for API hooks for a specific feature. This is an array of hook lists, each identified by a numeric identifier (id). Each array element is a list of all