[trafficserver] branch quic-latest updated: Remove an unneccessary function

[maskit]

This is an automated email from the ASF dual-hosted git repository.

maskit pushed a commit to branch quic-latest
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/quic-latest by this push:
     new b9928bf  Remove an unneccessary function
b9928bf is described below

commit b9928bf5f6d8a7551917c2c70482dc0d861dd318
Author: Masakazu Kitajo <mas...@apache.org>
AuthorDate: Wed Mar 6 15:47:32 2019 +0900

    Remove an unneccessary function
---
 iocore/net/P_QUICNetVConnection.h | 2 --
 iocore/net/QUICNetVConnection.cc  | 8 +-------
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/iocore/net/P_QUICNetVConnection.h 
b/iocore/net/P_QUICNetVConnection.h
index 670aaff..361d83b 100644
--- a/iocore/net/P_QUICNetVConnection.h
+++ b/iocore/net/P_QUICNetVConnection.h
@@ -290,8 +290,6 @@ private:
                     std::vector<QUICFrameInfo> &frames);
   QUICPacketUPtr _packetize_frames(QUICEncryptionLevel level, uint64_t 
max_packet_size);
   void _packetize_closing_frame();
-  QUICPacketUPtr _build_packet(ats_unique_buf buf, size_t len, bool 
retransmittable, bool probing, bool crypto,
-                               std::vector<QUICFrameInfo> &frames, 
QUICPacketType type = QUICPacketType::UNINITIALIZED);
   QUICPacketUPtr _build_packet(QUICEncryptionLevel level, ats_unique_buf buf, 
size_t len, bool retransmittable, bool probing,
                                bool crypto, std::vector<QUICFrameInfo> 
&frames);
 
diff --git a/iocore/net/QUICNetVConnection.cc b/iocore/net/QUICNetVConnection.cc
index c94f19d..410b235 100644
--- a/iocore/net/QUICNetVConnection.cc
+++ b/iocore/net/QUICNetVConnection.cc
@@ -1469,13 +1469,7 @@ QUICPacketUPtr
 QUICNetVConnection::_build_packet(QUICEncryptionLevel level, ats_unique_buf 
buf, size_t len, bool ack_eliciting, bool probing,
                                   bool crypto, std::vector<QUICFrameInfo> 
&frames)
 {
-  return this->_build_packet(std::move(buf), len, ack_eliciting, probing, 
crypto, frames, QUICTypeUtil::packet_type(level));
-}
-
-QUICPacketUPtr
-QUICNetVConnection::_build_packet(ats_unique_buf buf, size_t len, bool 
ack_eliciting, bool probing, bool crypto,
-                                  std::vector<QUICFrameInfo> &frames, 
QUICPacketType type)
-{
+  QUICPacketType type   = QUICTypeUtil::packet_type(level);
   QUICPacketUPtr packet = QUICPacketFactory::create_null_packet();
 
   switch (type) {