This is an automated email from the ASF dual-hosted git repository.

masaori pushed a commit to branch quic-latest
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/quic-latest by this push:
     new 08bcbdc  Add virtual destructor to HQClientSession / 
HQClientTransaction
08bcbdc is described below

commit 08bcbdc5f8656df6d36119f13ed862c8444b07c9
Author: Masaori Koshiba <[email protected]>
AuthorDate: Mon Mar 11 16:11:34 2019 +0900

    Add virtual destructor to HQClientSession / HQClientTransaction
---
 proxy/http3/Http3ClientSession.cc    | 2 --
 proxy/http3/Http3ClientSession.h     | 2 +-
 proxy/http3/Http3ClientTransaction.h | 2 +-
 3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/proxy/http3/Http3ClientSession.cc 
b/proxy/http3/Http3ClientSession.cc
index 3fdd13d..d1d4e2a 100644
--- a/proxy/http3/Http3ClientSession.cc
+++ b/proxy/http3/Http3ClientSession.cc
@@ -146,7 +146,6 @@ Http3ClientSession::~Http3ClientSession()
   this->_client_vc = nullptr;
   delete this->_local_qpack;
   delete this->_remote_qpack;
-  super::~HQClientSession();
 }
 
 const char *
@@ -198,7 +197,6 @@ Http3ClientSession::remote_qpack()
 Http09ClientSession::~Http09ClientSession()
 {
   this->_client_vc = nullptr;
-  super::~HQClientSession();
 }
 
 const char *
diff --git a/proxy/http3/Http3ClientSession.h b/proxy/http3/Http3ClientSession.h
index 996de11..190726a 100644
--- a/proxy/http3/Http3ClientSession.h
+++ b/proxy/http3/Http3ClientSession.h
@@ -33,7 +33,7 @@ public:
   using super = ProxyClientSession; ///< Parent type
 
   HQClientSession(NetVConnection *vc) : _client_vc(vc){};
-  ~HQClientSession();
+  virtual ~HQClientSession();
 
   // Implement VConnection interface
   VIO *do_io_read(Continuation *c, int64_t nbytes = INT64_MAX, MIOBuffer *buf 
= nullptr) override;
diff --git a/proxy/http3/Http3ClientTransaction.h 
b/proxy/http3/Http3ClientTransaction.h
index 9d415ad..2d16663 100644
--- a/proxy/http3/Http3ClientTransaction.h
+++ b/proxy/http3/Http3ClientTransaction.h
@@ -41,7 +41,7 @@ public:
   using super = ProxyClientTransaction;
 
   HQClientTransaction(HQClientSession *session, QUICStreamIO *stream_io);
-  ~HQClientTransaction();
+  virtual ~HQClientTransaction();
 
   // Implement ProxyClienTransaction interface
   void set_active_timeout(ink_hrtime timeout_in) override;

Reply via email to