[trafficserver] branch master updated: Move the delete to please clang-analyzer

[bcall]

This is an automated email from the ASF dual-hosted git repository.

bcall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 83e5b28  Move the delete to please clang-analyzer
83e5b28 is described below

commit 83e5b28cfb7612640f462543f47f7080d676da6e
Author: Leif Hedstrom <zw...@apache.org>
AuthorDate: Thu Apr 25 13:28:31 2019 +0800

    Move the delete to please clang-analyzer
---
 proxy/PluginVC.cc | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/proxy/PluginVC.cc b/proxy/PluginVC.cc
index 79abc43..569ea85 100644
--- a/proxy/PluginVC.cc
+++ b/proxy/PluginVC.cc
@@ -1283,7 +1283,7 @@ public:
   ~PVCTestDriver() override;
 
   void start_tests(RegressionTest *r_arg, int *pstatus_arg);
-  void run_next_test();
+  bool run_next_test();
   int main_handler(int event, void *data);
 
 private:
@@ -1307,12 +1307,12 @@ PVCTestDriver::start_tests(RegressionTest *r_arg, int 
*pstatus_arg)
   r       = r_arg;
   pstatus = pstatus_arg;
 
-  run_next_test();
-
-  SET_HANDLER(&PVCTestDriver::main_handler);
+  if (run_next_test()) {
+    SET_HANDLER(&PVCTestDriver::main_handler);
+  }
 }
 
-void
+bool
 PVCTestDriver::run_next_test()
 {
   unsigned a_index = i * 2;
@@ -1326,7 +1326,7 @@ PVCTestDriver::run_next_test()
       *pstatus = REGRESSION_TEST_FAILED;
     }
     delete this;
-    return;
+    return false;
   }
   completions_received = 0;
   i++;
@@ -1341,6 +1341,8 @@ PVCTestDriver::run_next_test()
   PluginVC *a_vc = core->connect();
 
   a->init_test(NET_VC_TEST_ACTIVE, this, a_vc, r, &netvc_tests_def[a_index], 
"PluginVC", "pvc_test_detail");
+
+  return true;
 }
 
 int